Patchwork linux-next: 20090925 - hvc driver build breaks with !HVC_CONSOLE

login
register
mail settings
Submitter Kamalesh Babulal
Date Sept. 25, 2009, 1:31 p.m.
Message ID <20090925133143.GD6831@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/34273/
State Accepted
Commit aa8b83cb0b48e3cac58a3b75ad9c556564c5fe9d
Headers show

Comments

Kamalesh Babulal - Sept. 25, 2009, 1:31 p.m.
Hi Stephen,

	next-20090925 randconfig build breaks on hvcs driver on powerpc,
with HVC_CONSOLE=n.

ERROR: ".hvc_put_chars" [drivers/char/hvcs.ko] undefined!
ERROR: ".hvc_get_chars" [drivers/char/hvcs.ko] undefined!

adding the dependency of HVC_CONSOLE helped

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
 drivers/char/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

			
			Kamalesh

Patch

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index a2a0e67..2583231 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -682,7 +682,7 @@  config VIRTIO_CONSOLE
 
 config HVCS
 	tristate "IBM Hypervisor Virtual Console Server support"
-	depends on PPC_PSERIES
+	depends on PPC_PSERIES && HVC_CONSOLE
 	help
 	  Partitionable IBM Power5 ppc64 machines allow hosting of
 	  firmware virtual consoles from one Linux partition by