Patchwork unbreak usb pass-through on linux.

login
register
mail settings
Submitter Gerd Hoffmann
Date Sept. 25, 2009, 12:15 p.m.
Message ID <1253880934-25029-1-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/34269/
State Superseded
Headers show

Comments

Gerd Hoffmann - Sept. 25, 2009, 12:15 p.m.
Changes:
  * Re-add the 'dev->fd = fd;' line which the qdev patches dropped
    by mistake.
  * call qdev_init() so the newly created usb device is plugged into
    a usb port and thus actually visible to the guest.
---
 usb-linux.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Aurelien Jarno - Sept. 25, 2009, 2:31 p.m.
On Fri, Sep 25, 2009 at 02:15:34PM +0200, Gerd Hoffmann wrote:
> Changes:
>   * Re-add the 'dev->fd = fd;' line which the qdev patches dropped
>     by mistake.
>   * call qdev_init() so the newly created usb device is plugged into
>     a usb port and thus actually visible to the guest.
> ---
>  usb-linux.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Good work. A SoB is missing though.

> diff --git a/usb-linux.c b/usb-linux.c
> index c434e4f..2b7b092 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -922,6 +922,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
>  
>      dev->bus_num = bus_num;
>      dev->addr = addr;
> +    dev->fd = fd;
>  
>      /* read the device description */
>      dev->descr_len = read(fd, dev->descr, sizeof(dev->descr));
> @@ -979,6 +980,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
>  
>      hostdev_link(dev);
>  
> +    qdev_init(&d->qdev);
>      return (USBDevice *) dev;
>  
>  fail:
> -- 
> 1.6.2.5
> 
> 
> 
>

Patch

diff --git a/usb-linux.c b/usb-linux.c
index c434e4f..2b7b092 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -922,6 +922,7 @@  static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
 
     dev->bus_num = bus_num;
     dev->addr = addr;
+    dev->fd = fd;
 
     /* read the device description */
     dev->descr_len = read(fd, dev->descr, sizeof(dev->descr));
@@ -979,6 +980,7 @@  static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
 
     hostdev_link(dev);
 
+    qdev_init(&d->qdev);
     return (USBDevice *) dev;
 
 fail: