diff mbox

[Committed,ARM,AArch64] Patches previously ok'd for stage1

Message ID 535937E6.2050307@arm.com
State New
Headers show

Commit Message

Kyrylo Tkachov April 24, 2014, 4:12 p.m. UTC 
On 24/04/14 14:44, Ryan Mansfield wrote:
> On 14-04-23 11:38 AM, Kyrill Tkachov wrote:
>> http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html
>> (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html)
> This patch breaks building arm-eabi with a 32bit host gcc.

Hi Ryan,

Does this patch fix it for you?
I'll test and bootstrap it on arm.

Kyrill

2014-04-24  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	* config/arm/aarch-common.c (aarch_rev16_shright_mask_imm_p):
	Use HOST_WIDE_INT_C for mask literal.
	(aarch_rev16_shleft_mask_imm_p): Likewise.



>
> e.g
>
> 	../../gcc/config/arm/aarch-common.c
> ../../gcc/config/arm/aarch-common.c:198: error: integer constant is too
> large for 'long' type
> ../../gcc/config/arm/aarch-common.c:205: error: integer constant is too
> large for 'long' type
> ../../gcc/config/arm/t-arm:83: recipe for target 'aarch-common.o' failed
> make[2]: *** [aarch-common.o] Error 1
>
>
> Regards,
>
> Ryan Mansfield
>

Comments

Ryan Mansfield April 24, 2014, 4:46 p.m. UTC | #1 
On 14-04-24 12:12 PM, Kyrill Tkachov wrote:
> On 24/04/14 14:44, Ryan Mansfield wrote:
>> On 14-04-23 11:38 AM, Kyrill Tkachov wrote:
>>> http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html
>>> (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html)
>> This patch breaks building arm-eabi with a 32bit host gcc.
>
> Hi Ryan,
>
> Does this patch fix it for you?
> I'll test and bootstrap it on arm.
>
> Kyrill
>
> 2014-04-24  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>      * config/arm/aarch-common.c (aarch_rev16_shright_mask_imm_p):
>      Use HOST_WIDE_INT_C for mask literal.
>      (aarch_rev16_shleft_mask_imm_p): Likewise.

Yes, your patch resolves the build issues. Thanks.

Regards,

Ryan Mansfield
Kyrylo Tkachov April 24, 2014, 4:50 p.m. UTC | #2 
On 24/04/14 17:46, Ryan Mansfield wrote:
> On 14-04-24 12:12 PM, Kyrill Tkachov wrote:
>> On 24/04/14 14:44, Ryan Mansfield wrote:
>>> On 14-04-23 11:38 AM, Kyrill Tkachov wrote:
>>>> http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html
>>>> (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html)
>>> This patch breaks building arm-eabi with a 32bit host gcc.
>> Hi Ryan,
>>
>> Does this patch fix it for you?
>> I'll test and bootstrap it on arm.
>>
>> Kyrill
>>
>> 2014-04-24  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>
>>       * config/arm/aarch-common.c (aarch_rev16_shright_mask_imm_p):
>>       Use HOST_WIDE_INT_C for mask literal.
>>       (aarch_rev16_shleft_mask_imm_p): Likewise.
> Yes, your patch resolves the build issues. Thanks.

Thanks for testing.
Regtest on cross arm-none-eabi passes. Bootstrap in progress.
Ok to commit if no issues then?

Kyrill

> Regards,
>
> Ryan Mansfield
>
>
Ramana Radhakrishnan April 25, 2014, 9:16 a.m. UTC | #3 
On Thu, Apr 24, 2014 at 5:50 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
> On 24/04/14 17:46, Ryan Mansfield wrote:
>>
>> On 14-04-24 12:12 PM, Kyrill Tkachov wrote:
>>>
>>> On 24/04/14 14:44, Ryan Mansfield wrote:
>>>>
>>>> On 14-04-23 11:38 AM, Kyrill Tkachov wrote:
>>>>>
>>>>> http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html
>>>>> (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html)
>>>>
>>>> This patch breaks building arm-eabi with a 32bit host gcc.
>>>
>>> Hi Ryan,
>>>
>>> Does this patch fix it for you?
>>> I'll test and bootstrap it on arm.

Ok - can people remember to build and test before applying their
patches even though they are OK'd ?

Ramana

>>>
>>> Kyrill
>>>
>>> 2014-04-24  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>>
>>>       * config/arm/aarch-common.c (aarch_rev16_shright_mask_imm_p):
>>>       Use HOST_WIDE_INT_C for mask literal.
>>>       (aarch_rev16_shleft_mask_imm_p): Likewise.
>>
>> Yes, your patch resolves the build issues. Thanks.
>
>
> Thanks for testing.
> Regtest on cross arm-none-eabi passes. Bootstrap in progress.
> Ok to commit if no issues then?
>
> Kyrill
>
>> Regards,
>>
>> Ryan Mansfield
>>
>>
>
>
diff mbox

Patch

commit 83b40d14694e0c89f293f19071f006c11a54ad22
Author: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Date:   Thu Apr 24 15:33:57 2014 +0100

    [ARM] Use HOST_WIDE_INT_C

diff --git a/gcc/config/arm/aarch-common.c b/gcc/config/arm/aarch-common.c
index 884d4b3..d31191a 100644
--- a/gcc/config/arm/aarch-common.c
+++ b/gcc/config/arm/aarch-common.c
@@ -195,14 +195,18 @@  bool
 aarch_rev16_shright_mask_imm_p (rtx val, enum machine_mode mode)
 {
   return CONST_INT_P (val)
-         && INTVAL (val) == trunc_int_for_mode (0xff00ff00ff00ff, mode);
+         && INTVAL (val)
+            == trunc_int_for_mode (HOST_WIDE_INT_C (0xff00ff00ff00ff),
+                                   mode);
 }
 
 bool
 aarch_rev16_shleft_mask_imm_p (rtx val, enum machine_mode mode)
 {
   return CONST_INT_P (val)
-         && INTVAL (val) == trunc_int_for_mode (0xff00ff00ff00ff00, mode);
+         && INTVAL (val)
+            == trunc_int_for_mode (HOST_WIDE_INT_C (0xff00ff00ff00ff00),
+                                   mode);
 }