From patchwork Thu Sep 24 05:21:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Rothwell X-Patchwork-Id: 34205 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 216C0B7B9D for ; Thu, 24 Sep 2009 15:21:11 +1000 (EST) Received: from smtps.tip.net.au (chilli.pcug.org.au [203.10.76.44]) by ozlabs.org (Postfix) with ESMTP id C7E1EB7B77 for ; Thu, 24 Sep 2009 15:21:04 +1000 (EST) Received: from canb.auug.org.au (ta-1-1.tip.net.au [203.11.71.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtps.tip.net.au (Postfix) with ESMTPSA id 0F5D8145183; Thu, 24 Sep 2009 15:21:03 +1000 (EST) Date: Thu, 24 Sep 2009 15:21:02 +1000 From: Stephen Rothwell To: ppc-dev Subject: linux-next: tree build failure Message-Id: <20090924152102.8d7d40cf.sfr@canb.auug.org.au> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; i486-pc-linux-gnu) Mime-Version: 1.0 Cc: Hollis Blanchard , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-next@vger.kernel.org, Jan Beulich , Andrew Morton X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Hi all, Today's linux-next build (powerpc ppc44x_defconfig) failed like this: In file included from arch/powerpc/kvm/booke.c:31: arch/powerpc/kvm/timing.h: In function 'kvmppc_account_exit_stat': arch/powerpc/kvm/timing.h:51: error: bit-field '' width not an integer constant In file included from arch/powerpc/kvm/booke.h:26, from arch/powerpc/kvm/booke_emulate.c:23: arch/powerpc/kvm/timing.h: In function 'kvmppc_account_exit_stat': arch/powerpc/kvm/timing.h:51: error: bit-field '' width not an integer constant Presumably caused by commit 8c87df457cb58fe75b9b893007917cf8095660a0 ("BUILD_BUG_ON(): fix it and a couple of bogus uses of it"). I applied the following patch for today. This inline function is only called from one place in one file ... From: Stephen Rothwell Date: Thu, 24 Sep 2009 15:13:20 +1000 Subject: [PATCH] powerpc/kvm: build fix for new BUILD_BUG_ON Signed-off-by: Stephen Rothwell --- arch/powerpc/kvm/timing.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kvm/timing.h b/arch/powerpc/kvm/timing.h index bb13b1f..4c34099 100644 --- a/arch/powerpc/kvm/timing.h +++ b/arch/powerpc/kvm/timing.h @@ -48,7 +48,7 @@ static inline void kvmppc_set_exit_type(struct kvm_vcpu *vcpu, int type) {} static inline void kvmppc_account_exit_stat(struct kvm_vcpu *vcpu, int type) { /* type has to be known at build time for optimization */ - BUILD_BUG_ON(__builtin_constant_p(type)); + //BUILD_BUG_ON(__builtin_constant_p(type)); switch (type) { case EXT_INTR_EXITS: vcpu->stat.ext_intr_exits++;