| Message ID | 1398293313-17580-2-git-send-email-s.martin49@gmail.com |
|---|---|
| State | Accepted |
| Commit | ea01826b90bbc2c4a35707058d9fd96bb700c525 |
| Headers | show |
On 24/04/14 00:48, Samuel Martin wrote: > Signed-off-by: Samuel Martin <s.martin49@gmail.com> > Cc: Arnout Vandecappelle <arnout@mind.be> Commit message could have been clarified with printf is POSIX-compliant, echo -e is not. Still, Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > > --- > changes v1 -> v2 > - new patch > --- > package/pkg-cmake.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk > index bf3db90..edda14a 100644 > --- a/package/pkg-cmake.mk > +++ b/package/pkg-cmake.mk > @@ -160,7 +160,7 @@ host-cmake-package = $(call inner-cmake-package,host-$(pkgname),$(call UPPERCASE > > $(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake: > @mkdir -p $(@D) > - @echo -en "\ > + @printf "\ > set(CMAKE_SYSTEM_NAME Linux)\n\ > set(CMAKE_C_COMPILER $(TARGET_CC_NOCCACHE))\n\ > set(CMAKE_CXX_COMPILER $(TARGET_CXX_NOCCACHE))\n\ >
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: > On 24/04/14 00:48, Samuel Martin wrote: >> Signed-off-by: Samuel Martin <s.martin49@gmail.com> >> Cc: Arnout Vandecappelle <arnout@mind.be> > Commit message could have been clarified with > printf is POSIX-compliant, echo -e is not. Committed with that added, thanks. It would also be good to get rid of the other instances of this in the tree: git grep -l 'echo -e' package/acpid/acpid.mk package/eudev/S10udev package/pkg-utils.mk package/udev/S10udev
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index bf3db90..edda14a 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -160,7 +160,7 @@ host-cmake-package = $(call inner-cmake-package,host-$(pkgname),$(call UPPERCASE $(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake: @mkdir -p $(@D) - @echo -en "\ + @printf "\ set(CMAKE_SYSTEM_NAME Linux)\n\ set(CMAKE_C_COMPILER $(TARGET_CC_NOCCACHE))\n\ set(CMAKE_CXX_COMPILER $(TARGET_CXX_NOCCACHE))\n\
Signed-off-by: Samuel Martin <s.martin49@gmail.com> Cc: Arnout Vandecappelle <arnout@mind.be> --- changes v1 -> v2 - new patch --- package/pkg-cmake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)