Patchwork Tweak an error msg a little

login
register
mail settings
Submitter Marek Polacek
Date April 23, 2014, 10:22 a.m.
Message ID <20140423102248.GB2103@redhat.com>
Download mbox | patch
Permalink /patch/341767/
State New
Headers show

Comments

Marek Polacek - April 23, 2014, 10:22 a.m.
I think it's better to be consistent and always quote the
"transaction_wrap" name, it even looks nicer.

I ran tm.exp tests, ok for trunk?

2014-04-23  Marek Polacek  <polacek@redhat.com>

	* c-common.c (handle_tm_wrap_attribute): Tweak error message.

	Marek
Richard Guenther - April 23, 2014, 10:41 a.m.
On Wed, Apr 23, 2014 at 12:22 PM, Marek Polacek <polacek@redhat.com> wrote:
> I think it's better to be consistent and always quote the
> "transaction_wrap" name, it even looks nicer.
>
> I ran tm.exp tests, ok for trunk?

Ok.

Thanks,
Richard.

> 2014-04-23  Marek Polacek  <polacek@redhat.com>
>
>         * c-common.c (handle_tm_wrap_attribute): Tweak error message.
>
> diff --git gcc/c-family/c-common.c gcc/c-family/c-common.c
> index 0b5ded8..a08c873 100644
> --- gcc/c-family/c-common.c
> +++ gcc/c-family/c-common.c
> @@ -8421,7 +8421,7 @@ handle_tm_wrap_attribute (tree *node, tree name, tree args,
>                 error ("%qD is not compatible with %qD", wrap_decl, decl);
>             }
>           else
> -           error ("transaction_wrap argument is not a function");
> +           error ("%qE argument is not a function", name);
>         }
>      }
>
>         Marek

Patch

diff --git gcc/c-family/c-common.c gcc/c-family/c-common.c
index 0b5ded8..a08c873 100644
--- gcc/c-family/c-common.c
+++ gcc/c-family/c-common.c
@@ -8421,7 +8421,7 @@  handle_tm_wrap_attribute (tree *node, tree name, tree args,
 		error ("%qD is not compatible with %qD", wrap_decl, decl);
 	    }
 	  else
-	    error ("transaction_wrap argument is not a function");
+	    error ("%qE argument is not a function", name);
 	}
     }