diff mbox

[1/1] cups: move localstatedir from /usr/var to /var

Message ID 1398214149-1914-1-git-send-email-danomimanchego123@gmail.com
State Accepted
Commit de59021d978ca3d0871e152aaada7ed2e939ad58
Headers show

Commit Message

Danomi Manchego April 23, 2014, 12:49 a.m. UTC
Prior to commit f64a1b850fc897357040bb4c58b6e5e50e71e094 ("cups:
convert to autotargets"), cups was explicitely configured to
put its modifiable single-machine data under /var.  After that
commit, the --localstatedir was not specified, so it remained at
it's default value, "PREFIX/var" - making cups use "/usr/var".

Using /var to store state files seems preferable to /usr/var,
as /usr might be read-only on some systems.  This patch
re-introduces the --localstatedir specification to build cups
to use /var.

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/cups/cups.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Peter Korsgaard May 4, 2014, 9:24 p.m. UTC | #1
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:

 > Prior to commit f64a1b850fc897357040bb4c58b6e5e50e71e094 ("cups:
 > convert to autotargets"), cups was explicitely configured to
 > put its modifiable single-machine data under /var.  After that
 > commit, the --localstatedir was not specified, so it remained at
 > it's default value, "PREFIX/var" - making cups use "/usr/var".

 > Using /var to store state files seems preferable to /usr/var,
 > as /usr might be read-only on some systems.  This patch
 > re-introduces the --localstatedir specification to build cups
 > to use /var.

 > Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/cups/cups.mk b/package/cups/cups.mk
index bcd6f1e..ee53735 100644
--- a/package/cups/cups.mk
+++ b/package/cups/cups.mk
@@ -17,7 +17,8 @@  CUPS_CONF_OPT = --without-perl \
 		--without-php \
 		--disable-gnutls \
 		--disable-gssapi \
-		--libdir=/usr/lib
+		--libdir=/usr/lib \
+		--localstatedir=/var
 CUPS_CONFIG_SCRIPTS = cups-config
 
 CUPS_DEPENDENCIES = $(if $(BR2_PACKAGE_ZLIB),zlib) \