Patchwork [07/24] Remove bogus error message from qemu_opts_set()

login
register
mail settings
Submitter Mark McLoughlin
Date Sept. 23, 2009, 10:24 a.m.
Message ID <1253701463-3134-8-git-send-email-markmc@redhat.com>
Download mbox | patch
Permalink /patch/34140/
State Superseded
Headers show

Comments

Mark McLoughlin - Sept. 23, 2009, 10:24 a.m.
The only way qemu_opts_create() can fail is if a QemuOpts with that id
already exists and fail_if_exists=1. In that case, we already print
an error which makes more sense than the one in qemu_opts_set().

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 qemu-option.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Patch

diff --git a/qemu-option.c b/qemu-option.c
index 9fe1f95..246f211 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -670,8 +670,6 @@  int qemu_opts_set(QemuOptsList *list, const char *id,
 
     opts = qemu_opts_create(list, id, 1);
     if (opts == NULL) {
-        fprintf(stderr, "id \"%s\" not found for \"%s\"\n",
-                id, list->name);
         return -1;
     }
     return qemu_opt_set(opts, name, value);