Patchwork [09/24] Remove double error message for -device option parsing

login
register
mail settings
Submitter Mark McLoughlin
Date Sept. 23, 2009, 10:24 a.m.
Message ID <1253701463-3134-10-git-send-email-markmc@redhat.com>
Download mbox | patch
Permalink /patch/34129/
State Superseded
Headers show

Comments

Mark McLoughlin - Sept. 23, 2009, 10:24 a.m.
qemu_opts_parse() gives a suitable error message in all failure cases
so we can remove the error message from the caller.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 vl.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Patch

diff --git a/vl.c b/vl.c
index 4ebd242..0f2e2f6 100644
--- a/vl.c
+++ b/vl.c
@@ -5240,9 +5240,7 @@  int main(int argc, char **argv, char **envp)
                 add_device_config(DEV_USB, optarg);
                 break;
             case QEMU_OPTION_device:
-                opts = qemu_opts_parse(&qemu_device_opts, optarg, "driver");
-                if (!opts) {
-                    fprintf(stderr, "parse error: %s\n", optarg);
+                if (!qemu_opts_parse(&qemu_device_opts, optarg, "driver")) {
                     exit(1);
                 }
                 break;