diff mbox

[U-Boot,RFC,2/3] cmd_pxe: remove SoC, ARCH path from pxe_default_path

Message ID 1398159826-29398-3-git-send-email-yamada.m@jp.panasonic.com
State RFC
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada April 22, 2014, 9:43 a.m. UTC
Drop CONFIG_SYS_ARCH and CONFIG_SYS_SOC from the code.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Rob Herring <robherring2@gmail.com>
Cc: Stephen Warren <swarren@nvidia.com>
---

 common/cmd_pxe.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Rob Herring April 22, 2014, 12:55 p.m. UTC | #1
On Tue, Apr 22, 2014 at 4:43 AM, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Drop CONFIG_SYS_ARCH and CONFIG_SYS_SOC from the code.

That is clear from the diff, but you are not stating why you need this change.

Rob

>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Rob Herring <robherring2@gmail.com>
> Cc: Stephen Warren <swarren@nvidia.com>
> ---
>
>  common/cmd_pxe.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/common/cmd_pxe.c b/common/cmd_pxe.c
> index 3483328..4b4a954 100644
> --- a/common/cmd_pxe.c
> +++ b/common/cmd_pxe.c
> @@ -18,10 +18,6 @@
>  #define MAX_TFTP_PATH_LEN 127
>
>  const char *pxe_default_paths[] = {
> -#ifdef CONFIG_SYS_SOC
> -       "default-" CONFIG_SYS_ARCH "-" CONFIG_SYS_SOC,
> -#endif
> -       "default-" CONFIG_SYS_ARCH,
>         "default",
>         NULL
>  };
> --
> 1.8.3.2
>
Stephen Warren April 22, 2014, 3:40 p.m. UTC | #2
On 04/22/2014 03:43 AM, Masahiro Yamada wrote:
> Drop CONFIG_SYS_ARCH and CONFIG_SYS_SOC from the code.

This seems like something that will be annoying to people who rely on
this behaviour; the patch removes functionality for no purpose.
diff mbox

Patch

diff --git a/common/cmd_pxe.c b/common/cmd_pxe.c
index 3483328..4b4a954 100644
--- a/common/cmd_pxe.c
+++ b/common/cmd_pxe.c
@@ -18,10 +18,6 @@ 
 #define MAX_TFTP_PATH_LEN 127
 
 const char *pxe_default_paths[] = {
-#ifdef CONFIG_SYS_SOC
-	"default-" CONFIG_SYS_ARCH "-" CONFIG_SYS_SOC,
-#endif
-	"default-" CONFIG_SYS_ARCH,
 	"default",
 	NULL
 };