From patchwork Mon Apr 21 18:42:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Fong X-Patchwork-Id: 340919 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 42B511400E5 for ; Tue, 22 Apr 2014 11:50:33 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9C2662724F; Mon, 21 Apr 2014 18:42:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0DwnYcC0k4Sl; Mon, 21 Apr 2014 18:42:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id A17A92F213; Mon, 21 Apr 2014 18:42:29 +0000 (UTC) X-Original-To: uclibc@lists.busybox.net Delivered-To: uclibc@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 6455F1BFA59 for ; Mon, 21 Apr 2014 18:42:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 60E9E8C571 for ; Mon, 21 Apr 2014 18:42:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EG5rDMaSrqMY for ; Mon, 21 Apr 2014 18:42:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by whitealder.osuosl.org (Postfix) with ESMTPS id 019128BC25 for ; Mon, 21 Apr 2014 18:42:27 +0000 (UTC) Received: by mail-pd0-f170.google.com with SMTP id v10so3985828pde.1 for ; Mon, 21 Apr 2014 11:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iH8VRqAUwbEpxb7mKbi1oJleZqXpbMh39u0enXi23zo=; b=eZtQCSWva+fVi9iF3PhppigUgRQwPXY2wJsYxArxi2iMCWujHc5laneNylDJzL3Mfo Gm5uV6CUtVRh8eroeAwz0PSHD93EDxA8Uhqs36NJrGMszTM5TWpSK+RyxSpBRMcwieIe OWEuCknaj62wirswHM9mET/U2d+gvon59LMWCkRekGHzaTQpYyVPjuDlFMY9t/lUxQIj CH2SujeLwaefykzhGZYKRi90oXmcDd671h+dw45CVUxc9pO36ajUutNQ54JSVvMUhFGo drh9MXcnT/oT0oJXpjw0xBgjA5tqRy4nLYkPDiGrs+8mSBq28qz+mcxN4HbWYHXtRCQr 6skA== X-Received: by 10.67.4.138 with SMTP id ce10mr39636613pad.12.1398105747722; Mon, 21 Apr 2014 11:42:27 -0700 (PDT) Received: from gregory-irv-00.broadcom.com (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPSA id xk3sm79596859pbb.65.2014.04.21.11.42.26 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Apr 2014 11:42:26 -0700 (PDT) From: Gregory Fong To: uclibc@uclibc.org Subject: [PATCH 2/3] ldso/mips: Remove redundant LD_DEBUG prints Date: Mon, 21 Apr 2014 11:42:00 -0700 Message-Id: <1398105721-23735-2-git-send-email-gregory.0xf0@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1398105721-23735-1-git-send-email-gregory.0xf0@gmail.com> References: <1398105721-23735-1-git-send-email-gregory.0xf0@gmail.com> X-BeenThere: uclibc@uclibc.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion and development of uClibc \(the embedded C library\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: uclibc-bounces@uclibc.org Sender: uclibc-bounces@uclibc.org These should have been protected by if (_dl_debug_reloc && _dl_debug_detail) , but since the previous change "ldso/mips: actually print results of each relocation" makes this redundant, just eliminate these prints instead. I think this is the only item that is still printing regardless of the value of LD_DEBUG when uClibc is built with SUPPORT_LD_DEBUG=y. Signed-off-by: Gregory Fong --- ldso/ldso/mips/elfinterp.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/ldso/ldso/mips/elfinterp.c b/ldso/ldso/mips/elfinterp.c index 8bcdddb..dfe37c5 100644 --- a/ldso/ldso/mips/elfinterp.c +++ b/ldso/ldso/mips/elfinterp.c @@ -240,20 +240,12 @@ int _dl_parse_relocation_information(struct dyn_elf *xpnt, case R_MIPS_TLS_DTPMOD32: if (tls_tpnt) *(ElfW(Word) *)reloc_addr = tls_tpnt->l_tls_modid; -#ifdef __SUPPORT_LD_DEBUG__ - _dl_dprintf(2, "TLS_DTPMOD : %s, %d, %d\n", - symname, old_val, *((unsigned int *)reloc_addr)); -#endif break; case R_MIPS_TLS_DTPREL64: case R_MIPS_TLS_DTPREL32: *(ElfW(Word) *)reloc_addr += TLS_DTPREL_VALUE (symbol_addr); -#ifdef __SUPPORT_LD_DEBUG__ - _dl_dprintf(2, "TLS_DTPREL : %s, %x, %x\n", - symname, old_val, *((unsigned int *)reloc_addr)); -#endif break; case R_MIPS_TLS_TPREL32: @@ -261,10 +253,6 @@ int _dl_parse_relocation_information(struct dyn_elf *xpnt, CHECK_STATIC_TLS((struct link_map *)tls_tpnt); *(ElfW(Addr) *)reloc_addr += TLS_TPREL_VALUE (tls_tpnt, symbol_addr); -#ifdef __SUPPORT_LD_DEBUG__ - _dl_dprintf(2, "TLS_TPREL : %s, %x, %x\n", - symname, old_val, *((unsigned long *)reloc_addr)); -#endif break; }