diff mbox

, PR target/60735, fix powerpc SPE failure

Message ID 20140421160210.GA28549@ibm-tiger.the-meissners.org
State New
Headers show

Commit Message

Michael Meissner April 21, 2014, 4:02 p.m. UTC 
Rohit says this more narrow patch for PR 60735 fixes the problem and does not
appear to have any other side effects.  I have done bootstrap builds on powerpc
Linux with no regressions.  Is it ok to apply to the 4.8, 4.9 branches and
trunk?

[gcc]
2014-04-17  Michael Meissner  <meissner@linux.vnet.ibm.com>

	PR target/60735
	* config/rs6000/rs6000.md (mov<mode>_softfloat32, FMOVE64 case):
	If mode is DDmode and TARGET_E500_DOUBLE allow move.

	* config/rs6000/rs6000.c (rs6000_debug_reg_global): Print some
	more debug information for E500 if -mdebug=reg.

[gcc/testsuite]
2014-04-17  Michael Meissner  <meissner@linux.vnet.ibm.com>

	PR target/60735
	* gcc.target/powerpc/pr60735.c: New test.  Insure _Decimal64 does
	not cause errors if -mspe.

Comments

David Edelsohn April 21, 2014, 6:55 p.m. UTC | #1 
On Mon, Apr 21, 2014 at 12:02 PM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> Rohit says this more narrow patch for PR 60735 fixes the problem and does not
> appear to have any other side effects.  I have done bootstrap builds on powerpc
> Linux with no regressions.  Is it ok to apply to the 4.8, 4.9 branches and
> trunk?
>
> [gcc]
> 2014-04-17  Michael Meissner  <meissner@linux.vnet.ibm.com>
>
>         PR target/60735
>         * config/rs6000/rs6000.md (mov<mode>_softfloat32, FMOVE64 case):
>         If mode is DDmode and TARGET_E500_DOUBLE allow move.
>
>         * config/rs6000/rs6000.c (rs6000_debug_reg_global): Print some
>         more debug information for E500 if -mdebug=reg.
>
> [gcc/testsuite]
> 2014-04-17  Michael Meissner  <meissner@linux.vnet.ibm.com>
>
>         PR target/60735
>         * gcc.target/powerpc/pr60735.c: New test.  Insure _Decimal64 does
>         not cause errors if -mspe.

Okay for trunk and 4.8 branch. Please coordinate with Jakub when 4.9
is open for 4.9.1 target.

Thanks, David
diff mbox

Patch

Index: gcc/config/rs6000/rs6000.md
===================================================================
--- gcc/config/rs6000/rs6000.md	(revision 209445)
+++ gcc/config/rs6000/rs6000.md	(working copy)
@@ -9395,7 +9395,8 @@  (define_insn "*mov<mode>_softfloat32"
 	(match_operand:FMOVE64 1 "input_operand" "r,Y,r,G,H,F"))]
   "! TARGET_POWERPC64 
    && ((TARGET_FPRS && TARGET_SINGLE_FLOAT) 
-       || TARGET_SOFT_FLOAT || TARGET_E500_SINGLE)
+       || TARGET_SOFT_FLOAT || TARGET_E500_SINGLE
+       || (<MODE>mode == DDmode && TARGET_E500_DOUBLE))
    && (gpc_reg_operand (operands[0], <MODE>mode)
        || gpc_reg_operand (operands[1], <MODE>mode))"
   "#"
Index: gcc/config/rs6000/rs6000.c
===================================================================
--- gcc/config/rs6000/rs6000.c	(revision 209445)
+++ gcc/config/rs6000/rs6000.c	(working copy)
@@ -2283,6 +2283,24 @@  rs6000_debug_reg_global (void)
   if (rs6000_float_gprs)
     fprintf (stderr, DEBUG_FMT_S, "float_gprs", "true");
 
+  fprintf (stderr, DEBUG_FMT_S, "fprs",
+	   (TARGET_FPRS ? "true" : "false"));
+
+  fprintf (stderr, DEBUG_FMT_S, "single_float",
+	   (TARGET_SINGLE_FLOAT ? "true" : "false"));
+
+  fprintf (stderr, DEBUG_FMT_S, "double_float",
+	   (TARGET_DOUBLE_FLOAT ? "true" : "false"));
+
+  fprintf (stderr, DEBUG_FMT_S, "soft_float",
+	   (TARGET_SOFT_FLOAT ? "true" : "false"));
+
+  fprintf (stderr, DEBUG_FMT_S, "e500_single",
+	   (TARGET_E500_SINGLE ? "true" : "false"));
+
+  fprintf (stderr, DEBUG_FMT_S, "e500_double",
+	   (TARGET_E500_DOUBLE ? "true" : "false"));
+
   if (TARGET_LINK_STACK)
     fprintf (stderr, DEBUG_FMT_S, "link_stack", "true");
 
Index: gcc/testsuite/gcc.target/powerpc/pr60735.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/pr60735.c	(revision 0)
+++ gcc/testsuite/gcc.target/powerpc/pr60735.c	(revision 0)
@@ -0,0 +1,11 @@ 
+/* { dg-do compile } */
+/* { dg-options "-mcpu=8540 -mspe -mabi=spe -mfloat-gprs=single -O2" } */
+/* { dg-skip-if "not an SPE target" { ! powerpc_spe_nocache } { "*" } { "" } } */
+
+/* In PR60735, the type _Decimal64 generated an insn not found message.  */
+
+void
+pr60735 (_Decimal64 *p, _Decimal64 *q)
+{
+  *p = *q;
+}