Patchwork phylib: Wake PHY state machine on interrupt

login
register
mail settings
Submitter David Miller
Date Oct. 8, 2008, 10:47 p.m.
Message ID <20081008.154743.187048380.davem@davemloft.net>
Download mbox | patch
Permalink /patch/3405/
State Not Applicable
Headers show

Comments

David Miller - Oct. 8, 2008, 10:47 p.m.
With a minor coding style fix, I've applied your patch
as below.  Thanks.

commit 0acb28396728f42b6b1553c85d27c37513796043
Author: Trent Piepho <tpiepho@freescale.com>
Date:   Wed Oct 8 15:46:57 2008 -0700

    phylib: Wake PHY state machine on interrupt
    
    This way the phy layer will respond to a change in phy state immediately,
    instead of up to one second later when the state machine timer runs.
    
    Signed-off-by: Trent Piepho <tpiepho@freescale.com>
    Acked-by: Andy Fleming <afleming@freescale.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 0433fcd..20cc82c 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -729,6 +729,12 @@  static void phy_change(struct work_struct *work)
 	if (err)
 		goto irq_enable_err;
 
+	/* Stop timer and run the state queue now.  The work function for
+	 * state_queue will start the timer up again.
+	 */
+	del_timer(&phydev->phy_timer);
+	schedule_work(&phydev->state_queue);
+
 	return;
 
 irq_enable_err: