From patchwork Sat Apr 19 19:08:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Whitney X-Patchwork-Id: 340491 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 013371400A9 for ; Sun, 20 Apr 2014 05:08:21 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161133AbaDSTIT (ORCPT ); Sat, 19 Apr 2014 15:08:19 -0400 Received: from mail-qa0-f42.google.com ([209.85.216.42]:45945 "EHLO mail-qa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161109AbaDSTIT (ORCPT ); Sat, 19 Apr 2014 15:08:19 -0400 Received: by mail-qa0-f42.google.com with SMTP id k15so2634938qaq.29 for ; Sat, 19 Apr 2014 12:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=PicNx70b+YaGn41Kv03fMGiuOb4RFUcLLJpRR4WoACM=; b=sEM0Ymu9mVvdCMptVmTtKr0TUZ8D/9/aznEDsEcNSWcKw2a/rL/OSIJwP/EFEQQ25t t88f2iOn3CmIb6FNSzY+jVjfo8kIqKVLovYax/spA5cDnCrndyODQwRO3oKb+hHmWf+o 3JVzEx0ZatGdBzztnzVp9R7AJ9ON6ZNgW5lfS9KnUEOcfQb14X2lhHbAW81j4ynfeWs8 XebX3fNP1Vi4P/zIJvqtktD8BQtW9QFOZHH4ND4XkO2O0Sk3idNWMA2PbOnsyGRHQ2Lp uCA6vxrrMWeZY+3eK0WGaZE1KHC7rcKiJXgz622BuJje3fFDfLdawIRt2PTnpdiSv0WO GHCg== X-Received: by 10.224.92.197 with SMTP id s5mr4332682qam.93.1397934498242; Sat, 19 Apr 2014 12:08:18 -0700 (PDT) Received: from wallace (c-75-67-250-69.hsd1.nh.comcast.net. [75.67.250.69]) by mx.google.com with ESMTPSA id j1sm57623174qan.32.2014.04.19.12.08.17 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 19 Apr 2014 12:08:17 -0700 (PDT) Date: Sat, 19 Apr 2014 15:08:15 -0400 From: Eric Whitney To: xfs@oss.sgi.com Cc: linux-ext4@vger.kernel.org Subject: [PATCH] ext4: fix check for zero range support in ext4/001 Message-ID: <20140419190815.GB2116@wallace> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Ext4/001 fails when run on a file system that does not support byte range zeroing. For example, an EOPNOTSUPP failure occurs when the test is run on a pre-3.15 extent-mapped file system. The code in the test intended to prevent this contains an apparent typo that results in a check for fallocate() rather than zero range support. Signed-off-by: Eric Whitney Reviewed-by: "Theodore Ts'o" --- tests/ext4/001 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ext4/001 b/tests/ext4/001 index d575d9a..827d806 100755 --- a/tests/ext4/001 +++ b/tests/ext4/001 @@ -45,7 +45,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 # real QA test starts here _supported_fs ext4 _supported_os Linux -_require_xfs_io_falloc "fzero" +_require_xfs_io_command "fzero" testfile=$TEST_DIR/001.$$