| Message ID | 20140419190815.GB2116@wallace |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Sat, Apr 19, 2014 at 03:08:15PM -0400, Eric Whitney wrote: > Ext4/001 fails when run on a file system that does not support byte range > zeroing. For example, an EOPNOTSUPP failure occurs when the test is run > on a pre-3.15 extent-mapped file system. The code in the test intended > to prevent this contains an apparent typo that results in a check for > fallocate() rather than zero range support. > > Signed-off-by: Eric Whitney <enwlinux@gmail.com> LGTM Reviewed-by: "Theodore Ts'o" <tytso@mit.edu> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/ext4/001 b/tests/ext4/001 index d575d9a..827d806 100755 --- a/tests/ext4/001 +++ b/tests/ext4/001 @@ -45,7 +45,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 # real QA test starts here _supported_fs ext4 _supported_os Linux -_require_xfs_io_falloc "fzero" +_require_xfs_io_command "fzero" testfile=$TEST_DIR/001.$$
Ext4/001 fails when run on a file system that does not support byte range zeroing. For example, an EOPNOTSUPP failure occurs when the test is run on a pre-3.15 extent-mapped file system. The code in the test intended to prevent this contains an apparent typo that results in a check for fallocate() rather than zero range support. Signed-off-by: Eric Whitney <enwlinux@gmail.com> --- tests/ext4/001 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)