diff mbox

[build] PR 43538: Don't overwrite CXXFLAGS_FOR_TARGET in config/mt-gnu

Message ID alpine.DEB.2.10.1404181025490.3692@laptop-mg.saclay.inria.fr
State New
Headers show

Commit Message

Marc Glisse April 18, 2014, 8:28 a.m. UTC 
Ping
http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01480.html

On Thu, 23 Jan 2014, Marc Glisse wrote:

> Hello,
>
> although setting CFLAGS_FOR_TARGET before compiling gcc works fine, 
> CXXFLAGS_FOR_TARGET is ignored. I don't see any good reason for that.
>
> I tested the patch by doing a regular bootstrap+testsuite on 
> x86_64-unknown-linux-gnu. I also did a non-bootstrap build where I set 
> CXXFLAGS_FOR_TARGET and checked that it now propagates to libstdc++ and 
> others.
>
> config/ChangeLog:
>
> 2014-01-23  Marc Glisse  <marc.glisse@inria.fr>
>
> 	PR target/43538
> 	* mt-gnu: Don't reset CXXFLAGS_FOR_TARGET.

Comments

Jeff Law April 24, 2014, 8:58 p.m. UTC | #1 
On 04/18/14 02:28, Marc Glisse wrote:
> Ping
> http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01480.html
>
> On Thu, 23 Jan 2014, Marc Glisse wrote:
>
>> Hello,
>>
>> although setting CFLAGS_FOR_TARGET before compiling gcc works fine,
>> CXXFLAGS_FOR_TARGET is ignored. I don't see any good reason for that.
>>
>> I tested the patch by doing a regular bootstrap+testsuite on
>> x86_64-unknown-linux-gnu. I also did a non-bootstrap build where I set
>> CXXFLAGS_FOR_TARGET and checked that it now propagates to libstdc++
>> and others.
>>
>> config/ChangeLog:
>>
>> 2014-01-23  Marc Glisse  <marc.glisse@inria.fr>
>>
>>     PR target/43538
>>     * mt-gnu: Don't reset CXXFLAGS_FOR_TARGET.
OK for the trunk.  Please install.

Jeff
diff mbox

Patch

Index: config/mt-gnu
===================================================================
--- config/mt-gnu	(revision 209514)
+++ config/mt-gnu	(working copy)
@@ -1 +1 @@ 
-CXXFLAGS_FOR_TARGET = $(CXXFLAGS) -D_GNU_SOURCE
+CXXFLAGS_FOR_TARGET += -D_GNU_SOURCE