| Message ID | 1397802352-27814-1-git-send-email-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
18.04.2014 10:25, Fam Zheng wrote: > There are two paths to show help and exit, one is with "-h" or "--help", > one is with invalid options. > > Only "exit 1" with the latter case. I'd rather put `exit 1' right in invalid option case, instead of jumping to help. Because help output is huge, and it is often difficult to see the error message. At max, at the error case, the script can output something like, `for a list of valid options, run $0 --help'. Here and for qemu-img case. Do you not agree? Thanks, /mjt
diff --git a/configure b/configure index 69b9f56..b195efe 100755 --- a/configure +++ b/configure @@ -1087,7 +1087,10 @@ for opt do ;; --enable-quorum) quorum="yes" ;; - *) echo "ERROR: unknown option $opt"; show_help="yes" + *) + echo "ERROR: unknown option $opt" + show_help="yes" + exit_code=1 ;; esac done @@ -1353,7 +1356,7 @@ Advanced options (experts only): NOTE: The object files are built at the place where configure is launched EOF -exit 1 +exit $exit_code fi # Now we have handled --enable-tcg-interpreter and know we're not just
There are two paths to show help and exit, one is with "-h" or "--help", one is with invalid options. Only "exit 1" with the latter case. Signed-off-by: Fam Zheng <famz@redhat.com> --- configure | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)