Patchwork [GIT,PULL] Renesas ARM Based SoC Boards Updates for v3.16

login
register
mail settings
Submitter Simon Horman
Date April 17, 2014, 10:44 p.m.
Message ID <cover.1397774190.git.horms+renesas@verge.net.au>
Download mbox
Permalink /patch/340092/
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-boards-for-v3.16

Comments

Simon Horman - April 17, 2014, 10:44 p.m.
Hi Olof, Hi Kevin, Hi Arnd,

Please consider these Renesas ARM Based SoC Boards Updates for v3.16.


This pull request is based on
3984ba10dddc5a10 ("ARM: shmobile: r8a7791: Rename VSP1_SY clocks to VSP1_S").

That commit is part of the pull request
"Renesas ARM Based SoC Clock Updates for v3.16",
tagged as renesas-clock-for-v3.16, which I have previously sent.

I have not rebased this pull-request on top of renesas-clock-for-v3.16
in order to avoid churn in linux-next.

The reason for basing this pull-request on clock updates is
that many of its patches depend on shmobile_clk_workaround() which
is added as part of the clock updates.


The following changes since commit 58ea1d53ba93620ac50fef9d9720b2323971f243:

  ARM: shmobile: r8a7791: Rename VSP1_SY clocks to VSP1_S (2014-04-14 11:30:11 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-boards-for-v3.16

for you to fetch changes up to a09b2f0ba170dc89a67d6c4c4f027b37a085dad9:

  ARM: shmobile: lager legacy: Enable Quad SPI transfers for the SPI FLASH (2014-04-15 08:13:22 +0900)

----------------------------------------------------------------
Renesas ARM Based SoC Boards Updates for v3.16

r8a7791 (R-Car M2) based Koelsch board
* Enable Quad SPI transfers for the SPI FLASH
* Clock workarounds for Ether, I2C, MSIOF, Quad SPI and SDHI
* Use shmobile_clk_workaround()

r8a7790 (R-Car H2) based Lager board
* Enable Quad SPI transfers for the SPI FLASH
* Switch to use dai info for R-Car sound
* Clock workarounds for Ether, MSIOF, MMCIF, Quad SPI and SDHI
* Use shmobile_clk_workaround()

r8a7778 (R-Car M1) based Bock-W board
* Switch to use dai info for R-Car sound

----------------------------------------------------------------
Geert Uytterhoeven (3):
      ARM: shmobile: koelsch-reference: Work around core clock issues
      ARM: shmobile: koelsch legacy: Enable Quad SPI transfers for the SPI FLASH
      ARM: shmobile: lager legacy: Enable Quad SPI transfers for the SPI FLASH

Kuninori Morimoto (3):
      ARM: shmobile: bockw: remove old style audio clock
      ARM: shmobile: bockw: switch to use dai info for R-Car sound
      ARM: shmobile: lager: switch to use dai info for R-Car sound

Magnus Damm (4):
      ARM: shmobile: Use shmobile_clk_workaround() on Lager
      ARM: shmobile: Use shmobile_clk_workaround() on Koelsch
      ARM: shmobile: Add Lager clock workarounds for SDHI and MMCIF
      ARM: shmobile: Add Koelsch clock workarounds for SDHI

Simon Horman (4):
      ARM: shmobile: koelsch: Annotate clk_names with __initconst
      ARM: shmobile: lager: Annotate clk_names with __initconst
      ARM: shmobile: koelsch-reference: Annotate clk_enables as __initconst
      ARM: shmobile: lager-reference: Work around core clock issues

 arch/arm/mach-shmobile/board-bockw.c             | 63 +++++++++++------
 arch/arm/mach-shmobile/board-koelsch-reference.c | 86 ++++++++++++------------
 arch/arm/mach-shmobile/board-koelsch.c           |  2 +-
 arch/arm/mach-shmobile/board-lager-reference.c   | 79 +++++++++++-----------
 arch/arm/mach-shmobile/board-lager.c             | 29 +++++---
 5 files changed, 142 insertions(+), 117 deletions(-)
Sergei Shtylyov - April 22, 2014, 8:27 p.m.
Hello.

On 04/18/2014 02:44 AM, Simon Horman wrote:

> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>

> Due to issues with runtime PM clock management, clocks not explicitly
> managed by their drivers may not be enabled at all, or be inadvertently
> disabled by the clk_disable_unused() late initcall.

> Until this is fixed, add a temporary workaround, calling
> shmobile_clk_workaround() with enable == true.

> For now this enables the clocks for: ether, i2c2, msiof0, qspi_mod, and
> thermal. More clocks can be added if needed.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

    It is strange but this workaround doesn't seem to help me booting Koelsch
reference kernel with NFS root: it still crashes due to imprecise external 
abort once the userland starts. Only the actual drivers/sh/ fixing series by 
Ben/Geert helps with booting further. I therefore would like to have it merged 
by Simon the sooner the better...

WBR, Sergei
Simon Horman - April 23, 2014, 12:22 a.m.
On Wed, Apr 23, 2014 at 12:27:36AM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 04/18/2014 02:44 AM, Simon Horman wrote:
> 
> >From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> 
> >Due to issues with runtime PM clock management, clocks not explicitly
> >managed by their drivers may not be enabled at all, or be inadvertently
> >disabled by the clk_disable_unused() late initcall.
> 
> >Until this is fixed, add a temporary workaround, calling
> >shmobile_clk_workaround() with enable == true.
> 
> >For now this enables the clocks for: ether, i2c2, msiof0, qspi_mod, and
> >thermal. More clocks can be added if needed.
> 
> >Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
>    It is strange but this workaround doesn't seem to help me booting Koelsch
> reference kernel with NFS root: it still crashes due to imprecise
> external abort once the userland starts. Only the actual drivers/sh/
> fixing series by Ben/Geert helps with booting further. I therefore
> would like to have it merged by Simon the sooner the better...

For my reference, specifically which patches are you referring to?
Sergei Shtylyov - April 23, 2014, 6:54 p.m.
Hello.

On 04/23/2014 04:22 AM, Simon Horman wrote:

>>> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>

>>> Due to issues with runtime PM clock management, clocks not explicitly
>>> managed by their drivers may not be enabled at all, or be inadvertently
>>> disabled by the clk_disable_unused() late initcall.

>>> Until this is fixed, add a temporary workaround, calling
>>> shmobile_clk_workaround() with enable == true.

>>> For now this enables the clocks for: ether, i2c2, msiof0, qspi_mod, and
>>> thermal. More clocks can be added if needed.

>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

>>     It is strange but this workaround doesn't seem to help me booting Koelsch
>> reference kernel with NFS root: it still crashes due to imprecise
>> external abort once the userland starts. Only the actual drivers/sh/

    Unfortunately, I currently don't have time to find out what is wrong with 
the workaround...

>> fixing series by Ben/Geert helps with booting further. I therefore
>> would like to have it merged by Simon the sooner the better...

> For my reference, specifically which patches are you referring to?

    Here the link to the cover letter of the 17 patch series:
http://marc.info/?l=linux-sh&m=139756526122104

WBR, Sergei
Geert Uytterhoeven - April 23, 2014, 7:57 p.m.
i Sergei,

On Wed, Apr 23, 2014 at 8:54 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>>> fixing series by Ben/Geert helps with booting further. I therefore
>>> would like to have it merged by Simon the sooner the better...
>
>> For my reference, specifically which patches are you referring to?
>
>    Here the link to the cover letter of the 17 patch series:
> http://marc.info/?l=linux-sh&m=139756526122104

I'm working on a solution using a different approach. Please stay tuned.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Olof Johansson - May 5, 2014, 9:11 p.m.
On Fri, Apr 18, 2014 at 07:44:53AM +0900, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
> 
> Please consider these Renesas ARM Based SoC Boards Updates for v3.16.
> 
> 
> This pull request is based on
> 3984ba10dddc5a10 ("ARM: shmobile: r8a7791: Rename VSP1_SY clocks to VSP1_S").
> 
> That commit is part of the pull request
> "Renesas ARM Based SoC Clock Updates for v3.16",
> tagged as renesas-clock-for-v3.16, which I have previously sent.
> 
> I have not rebased this pull-request on top of renesas-clock-for-v3.16
> in order to avoid churn in linux-next.
> 
> The reason for basing this pull-request on clock updates is
> that many of its patches depend on shmobile_clk_workaround() which
> is added as part of the clock updates.
> 
> 
> The following changes since commit 58ea1d53ba93620ac50fef9d9720b2323971f243:
> 
>   ARM: shmobile: r8a7791: Rename VSP1_SY clocks to VSP1_S (2014-04-14 11:30:11 +0900)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-boards-for-v3.16
> 
> for you to fetch changes up to a09b2f0ba170dc89a67d6c4c4f027b37a085dad9:
> 
>   ARM: shmobile: lager legacy: Enable Quad SPI transfers for the SPI FLASH (2014-04-15 08:13:22 +0900)

Merged, thanks.

-Olof