From patchwork Wed Oct 8 21:57:35 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guo-Fu Tseng X-Patchwork-Id: 3400 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 7914ADDF2C for ; Thu, 9 Oct 2008 08:58:10 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754354AbYJHV6F (ORCPT ); Wed, 8 Oct 2008 17:58:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754608AbYJHV6E (ORCPT ); Wed, 8 Oct 2008 17:58:04 -0400 Received: from 220-133-139-86.HINET-IP.hinet.net ([220.133.139.86]:34535 "EHLO cooldavid.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbYJHV6C (ORCPT ); Wed, 8 Oct 2008 17:58:02 -0400 Received: from cooldavid.org (localhost [127.0.0.1]) by cooldavid.org (Postfix) with ESMTP id 6663F67A4E; Thu, 9 Oct 2008 05:57:35 +0800 (CST) From: "Guo-Fu Tseng" To: Jeff Garzik Cc: netdev@vger.kernel.org, Ethan , akeemting Reply-To: cooldavid@cooldavid.org Subject: [PATCH net-next-2.6 2/3] jme: Faulty IRQ handle bug fix Date: Thu, 9 Oct 2008 05:57:35 +0800 Message-Id: <20081008215735.M67730@cooldavid.org> In-Reply-To: <48D27CDA.50501@pobox.com> References: <20080915165101.M68109@cooldavid.org> <48D27CDA.50501@pobox.com> X-Mailer: Open WebMail 2.51 20050228 X-OriginatingIP: 140.117.194.21 (cooldavid) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dear Jeff, David: This patch: Fix IRQ handle bug when interrupt mode. The driver was incorrectly handled and returned IRQ_HANDLED while the device is not generating the interrupt. It happened due to faulty determination of interrupt status register. The patch is also available at: http://cooldavid.org/download/jme.net-next-2.6.20081009.2.patch Found by: "Ethan" Fixed by: "akeemting" Signed-off-by: Guo-Fu Tseng --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/jme.c b/drivers/net/jme.c index 635f616..3ab2442 100644 --- a/drivers/net/jme.c +++ b/drivers/net/jme.c @@ -1463,7 +1463,7 @@ jme_intr(int irq, void *dev_id) /* * Check if it's really an interrupt for us */ - if (unlikely(intrstat == 0)) + if (unlikely((intrstat & INTR_ENABLE) == 0)) return IRQ_NONE; /*