Patchwork [net-next-2.6,2/3] jme: Faulty IRQ handle bug fix

login
register
mail settings
Submitter Guo-Fu Tseng
Date Oct. 8, 2008, 9:57 p.m.
Message ID <20081008215735.M67730@cooldavid.org>
Download mbox | patch
Permalink /patch/3400/
State Accepted
Delegated to: Jeff Garzik
Headers show

Comments

Guo-Fu Tseng - Oct. 8, 2008, 9:57 p.m.
Dear Jeff, David:

This patch:

    Fix IRQ handle bug when interrupt mode.

    The driver was incorrectly handled and returned IRQ_HANDLED
    while the device is not generating the interrupt.
    It happened due to faulty determination of interrupt status register.

    The patch is also available at:
    http://cooldavid.org/download/jme.net-next-2.6.20081009.2.patch

    Found by: "Ethan" <ethanhsiao@jmicron.com>
    Fixed by: "akeemting" <akeem@jmicron.com>
    Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 9, 2008, 2:51 a.m.
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Thu, 9 Oct 2008 05:57:35 +0800

> Dear Jeff, David:
> 
> This patch:
> 
>     Fix IRQ handle bug when interrupt mode.
> 
>     The driver was incorrectly handled and returned IRQ_HANDLED
>     while the device is not generating the interrupt.
>     It happened due to faulty determination of interrupt status register.
> 
>     The patch is also available at:
>     http://cooldavid.org/download/jme.net-next-2.6.20081009.2.patch
> 
>     Found by: "Ethan" <ethanhsiao@jmicron.com>
>     Fixed by: "akeemting" <akeem@jmicron.com>
>     Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/jme.c b/drivers/net/jme.c
index 635f616..3ab2442 100644
--- a/drivers/net/jme.c
+++ b/drivers/net/jme.c
@@ -1463,7 +1463,7 @@  jme_intr(int irq, void *dev_id)
 	/*
 	 * Check if it's really an interrupt for us
 	 */
-	if (unlikely(intrstat == 0))
+	if (unlikely((intrstat & INTR_ENABLE) == 0))
 		return IRQ_NONE;
 
 	/*