Patchwork clocksource: efm32: let CLKSRC_EFM32 select CLKSRC_OF

login
register
mail settings
Submitter Uwe Kleine-König
Date April 16, 2014, 6:40 p.m.
Message ID <1397673612-24247-1-git-send-email-u.kleine-koenig@pengutronix.de>
Download mbox | patch
Permalink /patch/339700/
State New
Headers show

Comments

Uwe Kleine-König - April 16, 2014, 6:40 p.m.
The efm32 timer driver is only usable with CLKSRC_OF, so it makes sense
to let its Kconfig symbol select it. For compile coverage testing it's not
needed though, so only select it if ARCH_EFM32 is enabled.

This allows to drop ARCH_EFM32 selecting CLKSRC_OF which is done here
for simplicity, too.

Reported-by: Rob Herring <robherring2@gmail.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/Kconfig            | 1 -
 drivers/clocksource/Kconfig | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
Rob Herring - April 16, 2014, 6:51 p.m.
On Wed, Apr 16, 2014 at 1:40 PM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> The efm32 timer driver is only usable with CLKSRC_OF, so it makes sense
> to let its Kconfig symbol select it. For compile coverage testing it's not
> needed though, so only select it if ARCH_EFM32 is enabled.
>
> This allows to drop ARCH_EFM32 selecting CLKSRC_OF which is done here
> for simplicity, too.
>
> Reported-by: Rob Herring <robherring2@gmail.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/Kconfig            | 1 -
>  drivers/clocksource/Kconfig | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ab438cb5af55..e345419fb112 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -424,7 +424,6 @@ config ARCH_EFM32
>         select ARCH_REQUIRE_GPIOLIB
>         select AUTO_ZRELADDR
>         select ARM_NVIC
> -       select CLKSRC_OF
>         select COMMON_CLK
>         select CPU_V7M
>         select GENERIC_CLOCKEVENTS
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -80,6 +80,7 @@ config CLKSRC_EFM32
>         bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32
>         depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST)
>         select CLKSRC_MMIO
> +       select CLKSRC_OF if ARCH_EFM32

You already depend on OF, so I believe you don't need the if here.

Rob
Uwe Kleine-König - April 16, 2014, 7:30 p.m.
Hello,

On Wed, Apr 16, 2014 at 01:51:17PM -0500, Rob Herring wrote:
> On Wed, Apr 16, 2014 at 1:40 PM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > The efm32 timer driver is only usable with CLKSRC_OF, so it makes sense
> > to let its Kconfig symbol select it. For compile coverage testing it's not
> > needed though, so only select it if ARCH_EFM32 is enabled.
> >
> > This allows to drop ARCH_EFM32 selecting CLKSRC_OF which is done here
> > for simplicity, too.
> >
> > Reported-by: Rob Herring <robherring2@gmail.com>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > [...]
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -80,6 +80,7 @@ config CLKSRC_EFM32
> >         bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32
> >         depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST)
> >         select CLKSRC_MMIO
> > +       select CLKSRC_OF if ARCH_EFM32
> 
> You already depend on OF, so I believe you don't need the if here.
Rob and I discussed this shortly on irc, the summary is that the if is
not needed to prevent Kconfig breakage but adds more flexibility for the
COMPILE_TEST case. In the end Rob said:

	1397676012 < robher> you can add my ack.

which would be:

Acked-by: Rob Herring <robherring2@gmail.com>

Best regards
Uwe
Daniel Lezcano - April 16, 2014, 7:56 p.m.
On 04/16/2014 09:30 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Apr 16, 2014 at 01:51:17PM -0500, Rob Herring wrote:
>> On Wed, Apr 16, 2014 at 1:40 PM, Uwe Kleine-König
>> <u.kleine-koenig@pengutronix.de> wrote:
>>> The efm32 timer driver is only usable with CLKSRC_OF, so it makes sense
>>> to let its Kconfig symbol select it. For compile coverage testing it's not
>>> needed though, so only select it if ARCH_EFM32 is enabled.
>>>
>>> This allows to drop ARCH_EFM32 selecting CLKSRC_OF which is done here
>>> for simplicity, too.
>>>
>>> Reported-by: Rob Herring <robherring2@gmail.com>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>> ---
>>> [...]
>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>> --- a/drivers/clocksource/Kconfig
>>> +++ b/drivers/clocksource/Kconfig
>>> @@ -80,6 +80,7 @@ config CLKSRC_EFM32
>>>          bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32
>>>          depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST)
>>>          select CLKSRC_MMIO
>>> +       select CLKSRC_OF if ARCH_EFM32
>>
>> You already depend on OF, so I believe you don't need the if here.
> Rob and I discussed this shortly on irc, the summary is that the if is
> not needed to prevent Kconfig breakage but adds more flexibility for the
> COMPILE_TEST case. In the end Rob said:
>
> 	1397676012 < robher> you can add my ack.
>
> which would be:
>
> Acked-by: Rob Herring <robherring2@gmail.com>

Ok, thanks.
Daniel Lezcano - April 17, 2014, 7:36 a.m.
On 04/16/2014 09:30 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Apr 16, 2014 at 01:51:17PM -0500, Rob Herring wrote:
>> On Wed, Apr 16, 2014 at 1:40 PM, Uwe Kleine-König
>> <u.kleine-koenig@pengutronix.de> wrote:
>>> The efm32 timer driver is only usable with CLKSRC_OF, so it makes sense
>>> to let its Kconfig symbol select it. For compile coverage testing it's not
>>> needed though, so only select it if ARCH_EFM32 is enabled.
>>>
>>> This allows to drop ARCH_EFM32 selecting CLKSRC_OF which is done here
>>> for simplicity, too.
>>>
>>> Reported-by: Rob Herring <robherring2@gmail.com>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>> ---
>>> [...]
>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>> --- a/drivers/clocksource/Kconfig
>>> +++ b/drivers/clocksource/Kconfig
>>> @@ -80,6 +80,7 @@ config CLKSRC_EFM32
>>>          bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32
>>>          depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST)
>>>          select CLKSRC_MMIO
>>> +       select CLKSRC_OF if ARCH_EFM32
>>
>> You already depend on OF, so I believe you don't need the if here.
> Rob and I discussed this shortly on irc, the summary is that the if is
> not needed to prevent Kconfig breakage but adds more flexibility for the
> COMPILE_TEST case. In the end Rob said:
>
> 	1397676012 < robher> you can add my ack.
>
> which would be:
>
> Acked-by: Rob Herring <robherring2@gmail.com>

Hi Rob,

shall I use the mail address above or robh@kernel.org ?
Rob Herring - April 17, 2014, 2:01 p.m.
On Thu, Apr 17, 2014 at 2:36 AM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> On 04/16/2014 09:30 PM, Uwe Kleine-König wrote:
>>
>> Hello,
>>
>> On Wed, Apr 16, 2014 at 01:51:17PM -0500, Rob Herring wrote:
>>>
>>> On Wed, Apr 16, 2014 at 1:40 PM, Uwe Kleine-König
>>> <u.kleine-koenig@pengutronix.de> wrote:
>>>>
>>>> The efm32 timer driver is only usable with CLKSRC_OF, so it makes sense
>>>> to let its Kconfig symbol select it. For compile coverage testing it's
>>>> not
>>>> needed though, so only select it if ARCH_EFM32 is enabled.
>>>>
>>>> This allows to drop ARCH_EFM32 selecting CLKSRC_OF which is done here
>>>> for simplicity, too.
>>>>
>>>> Reported-by: Rob Herring <robherring2@gmail.com>
>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>> ---
>>>> [...]
>>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>>> --- a/drivers/clocksource/Kconfig
>>>> +++ b/drivers/clocksource/Kconfig
>>>> @@ -80,6 +80,7 @@ config CLKSRC_EFM32
>>>>          bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32
>>>>          depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST)
>>>>          select CLKSRC_MMIO
>>>> +       select CLKSRC_OF if ARCH_EFM32
>>>
>>>
>>> You already depend on OF, so I believe you don't need the if here.
>>
>> Rob and I discussed this shortly on irc, the summary is that the if is
>> not needed to prevent Kconfig breakage but adds more flexibility for the
>> COMPILE_TEST case. In the end Rob said:
>>
>>         1397676012 < robher> you can add my ack.
>>
>> which would be:
>>
>> Acked-by: Rob Herring <robherring2@gmail.com>
>
>
> Hi Rob,
>
> shall I use the mail address above or robh@kernel.org ?

kernel.org please.

Rob

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index ab438cb5af55..e345419fb112 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -424,7 +424,6 @@  config ARCH_EFM32
 	select ARCH_REQUIRE_GPIOLIB
 	select AUTO_ZRELADDR
 	select ARM_NVIC
-	select CLKSRC_OF
 	select COMMON_CLK
 	select CPU_V7M
 	select GENERIC_CLOCKEVENTS
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -80,6 +80,7 @@  config CLKSRC_EFM32
 	bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32
 	depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST)
 	select CLKSRC_MMIO
+	select CLKSRC_OF if ARCH_EFM32
 	default ARCH_EFM32
 	help
 	  Support to use the timers of EFM32 SoCs as clock source and clock