| Message ID | 1397655787-27780-1-git-send-email-iryzhov@arccn.ru |
|---|---|
| State | New |
| Headers | show |
Am 16.04.2014 15:43, schrieb Igor Ryzhov: > Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru> > --- > net/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/net.c b/net/net.c > index e3ef1e4..60a07f1 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender, > > if (ret == 0) { > nc->receive_disabled = 1; > - }; > + } > > return ret; > } > Reviewed-by: Stefan Weil <sw@weilnetz.de> CC'ing qemu-trivial PS. The "." at the end of your subject line is unnecessary, too. :-)
On 16 April 2014 18:32, Stefan Weil <sw@weilnetz.de> wrote: > Am 16.04.2014 15:43, schrieb Igor Ryzhov: >> Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru> >> --- >> net/net.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/net.c b/net/net.c >> index e3ef1e4..60a07f1 100644 >> --- a/net/net.c >> +++ b/net/net.c >> @@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender, >> >> if (ret == 0) { >> nc->receive_disabled = 1; >> - }; >> + } >> >> return ret; >> } >> > > Reviewed-by: Stefan Weil <sw@weilnetz.de> > > CC'ing qemu-trivial > > PS. The "." at the end of your subject line is unnecessary, too. :-) "net/net.c: Remove unnecessary semicolon" would probably be better (since it lets people know which area the patch is affecting and also gets the name of the punctuation mark right ;-)). thanks -- PMM
Oh, my mistake. It's really semicolon, not comma :) Should I resend the patch with correct name? 16.04.2014 21:58, Peter Maydell пишет: > On 16 April 2014 18:32, Stefan Weil <sw@weilnetz.de> wrote: >> Am 16.04.2014 15:43, schrieb Igor Ryzhov: >>> Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru> >>> --- >>> net/net.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/net/net.c b/net/net.c >>> index e3ef1e4..60a07f1 100644 >>> --- a/net/net.c >>> +++ b/net/net.c >>> @@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender, >>> >>> if (ret == 0) { >>> nc->receive_disabled = 1; >>> - }; >>> + } >>> >>> return ret; >>> } >>> >> Reviewed-by: Stefan Weil <sw@weilnetz.de> >> >> CC'ing qemu-trivial >> >> PS. The "." at the end of your subject line is unnecessary, too. :-) > "net/net.c: Remove unnecessary semicolon" would probably > be better (since it lets people know which area the patch is affecting > and also gets the name of the punctuation mark right ;-)). > > thanks > -- PMM
On Wed, Apr 16, 2014 at 05:43:07PM +0400, Igor Ryzhov wrote: > Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru> > --- > net/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) No need to resend, I fixed up the commit message. Thanks, applied to my net-next tree: https://github.com/stefanha/qemu/commits/net-next Stefan
Thanks, applied to the trivial queue, with subject tweak.
diff --git a/net/net.c b/net/net.c index e3ef1e4..60a07f1 100644 --- a/net/net.c +++ b/net/net.c @@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender, if (ret == 0) { nc->receive_disabled = 1; - }; + } return ret; }
Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru> --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)