| Message ID | 1397509552-5278-5-git-send-email-s.martin49@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Samuel Martin, On Mon, 14 Apr 2014 23:05:51 +0200, Samuel Martin wrote: > This will automatically take care of adding the right host-python package > to the dependency list and it will avoid trying to build python-pyrex using > python3. > > Signed-off-by: Samuel Martin <s.martin49@gmail.com> > --- > package/python-pyrex/python-pyrex.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Did you actually verify the python-pyrex only works with Python 2 ? Your commit log doesn't even say that. Thomas
On Mon, Apr 14, 2014 at 11:15 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Samuel Martin, > > On Mon, 14 Apr 2014 23:05:51 +0200, Samuel Martin wrote: >> This will automatically take care of adding the right host-python package >> to the dependency list and it will avoid trying to build python-pyrex using >> python3. >> >> Signed-off-by: Samuel Martin <s.martin49@gmail.com> >> --- >> package/python-pyrex/python-pyrex.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Did you actually verify the python-pyrex only works with Python 2 ? > Your commit log doesn't even say that. Yes, I did check it. Sorry for missing this in the commit log :s Do you mind add it when you'll apply the patch or should I repost it? > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
Dear Samuel Martin, On Mon, 14 Apr 2014 23:22:55 +0200, Samuel Martin wrote: > Yes, I did check it. > Sorry for missing this in the commit log :s > Do you mind add it when you'll apply the patch or should I repost it? Since you're going to resend for patches 1 and 2, you can also fix that patch 4 and resend it :-) Thanks! Thomas
diff --git a/package/python-pyrex/python-pyrex.mk b/package/python-pyrex/python-pyrex.mk index 73cb163..7f424ad 100644 --- a/package/python-pyrex/python-pyrex.mk +++ b/package/python-pyrex/python-pyrex.mk @@ -7,9 +7,9 @@ PYTHON_PYREX_VERSION = 0.9.9 PYTHON_PYREX_SOURCE = Pyrex-$(PYTHON_PYREX_VERSION).tar.gz PYTHON_PYREX_SITE = http://www.cosc.canterbury.ac.nz/greg.ewing/python/Pyrex/ -PYTHON_PYREX_DEPENDENCIES = host-python PYTHON_PYREX_LICENSE = Apache-v2 PYTHON_PYREX_LICENSE_FILES = LICENSE.txt PYTHON_PYREX_SETUP_TYPE = distutils +HOST_PYTHON_PYREX_NEEDS_HOST_PYTHON = python2 $(eval $(host-python-package))
This will automatically take care of adding the right host-python package to the dependency list and it will avoid trying to build python-pyrex using python3. Signed-off-by: Samuel Martin <s.martin49@gmail.com> --- package/python-pyrex/python-pyrex.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)