From patchwork Mon Apr 14 16:32:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Whitcroft X-Patchwork-Id: 339001 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 7DF53140089; Tue, 15 Apr 2014 02:33:04 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1WZjoa-0000Ha-D3; Mon, 14 Apr 2014 16:33:00 +0000 Received: from mail-wg0-f52.google.com ([74.125.82.52]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1WZjoV-0000Ae-9Y for kernel-team@lists.ubuntu.com; Mon, 14 Apr 2014 16:32:55 +0000 Received: by mail-wg0-f52.google.com with SMTP id k14so8421029wgh.35 for ; Mon, 14 Apr 2014 09:32:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=DXDa4r+GGUBxPeEurFtMOhiysgPN6p/pYMCde7lHNm0=; b=KcTiwf41hW7ehWdaworfgvF1FH1PJNeGHtBjdCIiJWyU9Vk3j1Usel8EPvVdIzR3xg 6H4KuJ+GIxj7GrVysJ2zctO/6qtq66M5z7Ph0Vbt+cUpAxo0LFknXqA8p+iNAeEyRf0M u8O2tn4zoHP+U1ssgWcIjzIYFjG8yqBouW1wJjAeW1flY4bJP3VqPHaGuqzU9fEN2s2v H+E2sxb4+V8VrzccIpZTUGcmDg3Obcw3KJr3KJ7WoIMos/dop1+P6+J2iUandA5t2bvw eiBN7JqPwCP7j0LMdSStQRAin2vlvsbA4ia+FZjBojdZb7/iS/9o7O7y4xM9fEhU7lVn QjWA== X-Gm-Message-State: ALoCoQm3OuCc+F0nL4Lm7QFhI0ASRG/Wwx8GwhM/TCtLd2ojDay0fWGPJGw0pr2bf5VCTFtcdene X-Received: by 10.180.10.164 with SMTP id j4mr10317078wib.51.1397493174994; Mon, 14 Apr 2014 09:32:54 -0700 (PDT) Received: from localhost ([2001:470:6973:2:c945:3b2c:585b:ddad]) by mx.google.com with ESMTPSA id et5sm1320018wib.8.2014.04.14.09.32.53 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 14 Apr 2014 09:32:54 -0700 (PDT) Date: Mon, 14 Apr 2014 17:32:52 +0100 From: Andy Whitcroft To: Joseph Salisbury Subject: Re: [Trusty][PATCH 0/1] powerpc: Increase COMMAND_LINE_SIZE to 2048 from 512. Message-ID: <20140414163252.GB6493@bark> References: <53489F11.1020708@canonical.com> <534AD03E.6050201@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <534AD03E.6050201@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: kernel-team@lists.ubuntu.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com On Sun, Apr 13, 2014 at 01:58:22PM -0400, Joseph Salisbury wrote: > On 04/11/2014 10:04 PM, Tim Gardner wrote: > > As this only increases the size of a static buffer, its hard to > > imagine how it might go wrong. > > > > I think you should send this upstream. > > > > rtg > Thanks, Tim. I'll send this upstream. Just to let you know, due to upstream code madness ppc does not actually use the define in the ppc headers but uses the common generic default. This likely needs to become a configurable. In the sort term I have switch the patch to the below, moving the default up to 2048. This moves it to 2048 for all architectures using the default, arm has its own 1024 override, and x86 overrides it to 2048 already. So this should have the same effect. Joe is owning getting some sanity for this upstream. -apw From 1bdb0ce803e331f51f7edbc408f7feffc2f25b5c Mon Sep 17 00:00:00 2001 From: Andy Whitcroft Date: Mon, 14 Apr 2014 09:14:22 +0100 Subject: [PATCH] UBUNTU: SAUCE: (no-up) powerpc: Increase COMMAND_LINE_SIZE to 2048 from 512. BugLink: http://bugs.launchpad.net/bugs/1306677 Powerpc currently does not actually use its own define, but instead uses the common unconfigurable define. We should be able to configure this per architecture, but we cannot. Signed-off-by: Andy Whitcroft --- include/uapi/asm-generic/setup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/asm-generic/setup.h b/include/uapi/asm-generic/setup.h index 6fc26a5..11decf0 100644 --- a/include/uapi/asm-generic/setup.h +++ b/include/uapi/asm-generic/setup.h @@ -1,6 +1,6 @@ #ifndef __ASM_GENERIC_SETUP_H #define __ASM_GENERIC_SETUP_H -#define COMMAND_LINE_SIZE 512 +#define COMMAND_LINE_SIZE 2048 #endif /* __ASM_GENERIC_SETUP_H */