[Trusty,0/1] powerpc: Increase COMMAND_LINE_SIZE to 2048 from 512.
diff mbox

Message ID 20140414163252.GB6493@bark
State New
Headers show

Commit Message

Andy Whitcroft April 14, 2014, 4:32 p.m. UTC
On Sun, Apr 13, 2014 at 01:58:22PM -0400, Joseph Salisbury wrote:
> On 04/11/2014 10:04 PM, Tim Gardner wrote:
> > As this only increases the size of a static buffer, its hard to
> > imagine how it might go wrong.
> >
> > I think you should send this upstream.
> >
> > rtg
> Thanks, Tim.  I'll send this upstream.

Just to let you know, due to upstream code madness ppc does not actually
use the define in the ppc headers but uses the common generic default.
This likely needs to become a configurable.  In the sort term I have
switch the patch to the below, moving the default up to 2048.  This
moves it to 2048 for all architectures using the default, arm has its
own 1024 override, and x86 overrides it to 2048 already.  So this should
have the same effect.

Joe is owning getting some sanity for this upstream.

-apw

From 1bdb0ce803e331f51f7edbc408f7feffc2f25b5c Mon Sep 17 00:00:00 2001
From: Andy Whitcroft <apw@canonical.com>
Date: Mon, 14 Apr 2014 09:14:22 +0100
Subject: [PATCH] UBUNTU: SAUCE: (no-up) powerpc: Increase COMMAND_LINE_SIZE to
 2048 from 512.

BugLink: http://bugs.launchpad.net/bugs/1306677

Powerpc currently does not actually use its own define, but instead
uses the common unconfigurable define.  We should be able to configure
this per architecture, but we cannot.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
 include/uapi/asm-generic/setup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch
diff mbox

diff --git a/include/uapi/asm-generic/setup.h b/include/uapi/asm-generic/setup.h
index 6fc26a5..11decf0 100644
--- a/include/uapi/asm-generic/setup.h
+++ b/include/uapi/asm-generic/setup.h
@@ -1,6 +1,6 @@ 
 #ifndef __ASM_GENERIC_SETUP_H
 #define __ASM_GENERIC_SETUP_H
 
-#define COMMAND_LINE_SIZE	512
+#define COMMAND_LINE_SIZE	2048
 
 #endif	/* __ASM_GENERIC_SETUP_H */