diff mbox

powerpc: Fix error return in rtas_flash module init

Message ID 20140414212332.366dce39@kryten (mailing list archive)
State Accepted
Commit 0c930692107be4b91c3eeecfd9c9d600039f966f
Delegated to: Benjamin Herrenschmidt
Headers show

Commit Message

Anton Blanchard April 14, 2014, 11:23 a.m. UTC 
module_init should return 0 or a negative errno.

Signed-off-by: Anton Blanchard <anton@samba.org>
---
diff mbox

Patch

diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c
index 2f3cdb0..658e89d 100644
--- a/arch/powerpc/kernel/rtas_flash.c
+++ b/arch/powerpc/kernel/rtas_flash.c
@@ -705,7 +705,7 @@  static int __init rtas_flash_init(void)
 	if (rtas_token("ibm,update-flash-64-and-reboot") ==
 		       RTAS_UNKNOWN_SERVICE) {
 		pr_info("rtas_flash: no firmware flash support\n");
-		return 1;
+		return -EINVAL;
 	}
 
 	rtas_validate_flash_data.buf = kzalloc(VALIDATE_BUF_SIZE, GFP_KERNEL);