diff mbox

Fix gcc.dg/lto/pr55113_0.c testsuite ICE

Message ID yddr4509mwq.fsf@lokon.CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth April 14, 2014, 11:21 a.m. UTC
Richard Biener <rguenther@suse.de> writes:

> This fixes gcc.dg/lto/pr55113_0.c ICEing on x86_64 with -m32
> (due to implicit -march=x86-64) by dg-skipping for all
> x86_64 and the -m64 i?86 variants (untested, not sure what
> -march default we use there - this just removes incrementally
> more x86_64 multilibs.
>
> Committed.
>
> Richard.
>
> 2014-03-31  Richard Biener  <rguenther@suse.de>
>
> 	* gcc.dg/lto/pr55113_0.c: Skip also for 32bit multilib on x86_64.
>
> Index: gcc/testsuite/gcc.dg/lto/pr55113_0.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/lto/pr55113_0.c	(revision 208954)
> +++ gcc/testsuite/gcc.dg/lto/pr55113_0.c	(working copy)
> @@ -1,7 +1,7 @@
>  /* PR 55113 */
>  /* { dg-lto-do link } */
>  /* { dg-lto-options { { -flto -fshort-double -O0 } } }*/
> -/* { dg-skip-if "PR60410" { { x86_64-*-* i?86-*-* } && lp64 } } */
> +/* { dg-skip-if "PR60410" { x86_64-*-* || { i?86-*-* && lp64 } } } */
>  
>  int 
>  main(void)

The test still fails on bi-arch Solaris 10 and 11/x86, but not on
32-bit-only Solaris 9/x86:

FAIL: gcc.dg/lto/pr55113 c_lto_pr55113_0.o assemble,  -flto -fshort-double -O0  (internal compiler error)
UNRESOLVED: gcc.dg/lto/pr55113 c_lto_pr55113_0.o-c_lto_pr55113_0.o link  -flto -fshort-double -O0 
UNRESOLVED: gcc.dg/lto/pr55113 c_lto_pr55113_0.o-c_lto_pr55113_0.o execute  -flto -fshort-double -O0 

Thus I'd like to skip it there, too, as follows.

Tested with the appropriate runtest invocations on i386-pc-solaris2.11,
x86_64-pc-solaris2.11, i686-unknown-linux-gnu, and
x86_64-unknown-linux-gnu.

Ok for mainline and 4.9 branch?

Thanks.
        Rainer


2014-04-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* gcc.dg/lto/pr55113_0.c: Skip on i?86-*-solaris2.1[0-1]*.

Comments

Richard Biener April 14, 2014, 11:56 a.m. UTC | #1
On Mon, 14 Apr 2014, Rainer Orth wrote:

> Richard Biener <rguenther@suse.de> writes:
> 
> > This fixes gcc.dg/lto/pr55113_0.c ICEing on x86_64 with -m32
> > (due to implicit -march=x86-64) by dg-skipping for all
> > x86_64 and the -m64 i?86 variants (untested, not sure what
> > -march default we use there - this just removes incrementally
> > more x86_64 multilibs.
> >
> > Committed.
> >
> > Richard.
> >
> > 2014-03-31  Richard Biener  <rguenther@suse.de>
> >
> > 	* gcc.dg/lto/pr55113_0.c: Skip also for 32bit multilib on x86_64.
> >
> > Index: gcc/testsuite/gcc.dg/lto/pr55113_0.c
> > ===================================================================
> > --- gcc/testsuite/gcc.dg/lto/pr55113_0.c	(revision 208954)
> > +++ gcc/testsuite/gcc.dg/lto/pr55113_0.c	(working copy)
> > @@ -1,7 +1,7 @@
> >  /* PR 55113 */
> >  /* { dg-lto-do link } */
> >  /* { dg-lto-options { { -flto -fshort-double -O0 } } }*/
> > -/* { dg-skip-if "PR60410" { { x86_64-*-* i?86-*-* } && lp64 } } */
> > +/* { dg-skip-if "PR60410" { x86_64-*-* || { i?86-*-* && lp64 } } } */
> >  
> >  int 
> >  main(void)
> 
> The test still fails on bi-arch Solaris 10 and 11/x86, but not on
> 32-bit-only Solaris 9/x86:
> 
> FAIL: gcc.dg/lto/pr55113 c_lto_pr55113_0.o assemble,  -flto -fshort-double -O0  (internal compiler error)
> UNRESOLVED: gcc.dg/lto/pr55113 c_lto_pr55113_0.o-c_lto_pr55113_0.o link  -flto -fshort-double -O0 
> UNRESOLVED: gcc.dg/lto/pr55113 c_lto_pr55113_0.o-c_lto_pr55113_0.o execute  -flto -fshort-double -O0 
> 
> Thus I'd like to skip it there, too, as follows.
> 
> Tested with the appropriate runtest invocations on i386-pc-solaris2.11,
> x86_64-pc-solaris2.11, i686-unknown-linux-gnu, and
> x86_64-unknown-linux-gnu.
> 
> Ok for mainline and 4.9 branch?

Interesting.  I suppose this config has SSE enabled by default?  Thus
it may apply to i?86-darwin as well.

Ok anyway.

Thanks,
Richard.

> Thanks.
>         Rainer
> 
> 
> 2014-04-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	* gcc.dg/lto/pr55113_0.c: Skip on i?86-*-solaris2.1[0-1]*.
Rainer Orth April 14, 2014, 2:51 p.m. UTC | #2
Richard Biener <rguenther@suse.de> writes:

> Interesting.  I suppose this config has SSE enabled by default?  Thus

Right, unlike i386-pc-solaris2.9.

> it may apply to i?86-darwin as well.

In my Darwin builds there's no LTO support, so it's unaffected.  No idea
if gld or gold do support that target, though.

	Rainer
diff mbox

Patch

# HG changeset patch
# Parent 855d3370af5b396ab39dbf2f95e90f315f6e9cac
Skip gcc.dg/lto/pr55113 on Solaris 10+/x86

diff --git a/gcc/testsuite/gcc.dg/lto/pr55113_0.c b/gcc/testsuite/gcc.dg/lto/pr55113_0.c
--- a/gcc/testsuite/gcc.dg/lto/pr55113_0.c
+++ b/gcc/testsuite/gcc.dg/lto/pr55113_0.c
@@ -2,6 +2,7 @@ 
 /* { dg-lto-do link } */
 /* { dg-lto-options { { -flto -fshort-double -O0 } } }*/
 /* { dg-skip-if "PR60410" { x86_64-*-* || { i?86-*-* && lp64 } } } */
+/* { dg-skip-if "PR60410" { i?86-*-solaris2.1[0-9]* } } */
 
 int 
 main(void)