Patchwork [1/1] ide: use printk_once

login
register
mail settings
Submitter Andrew Morton
Date Sept. 18, 2009, 7:49 p.m.
Message ID <200909181949.n8IJnmBN019766@imap1.linux-foundation.org>
Download mbox | patch
Permalink /patch/33884/
State Accepted
Delegated to: David Miller
Headers show

Comments

Andrew Morton - Sept. 18, 2009, 7:49 p.m.
From: Marcin Slusarz <marcin.slusarz@gmail.com>

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/ide/ide-proc.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
David Miller - Sept. 22, 2009, 11:29 p.m.
From: akpm@linux-foundation.org
Date: Fri, 18 Sep 2009 12:49:48 -0700

> From: Marcin Slusarz <marcin.slusarz@gmail.com>
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Acked-by: David S. Miller <davem@davemloft.net>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff -puN drivers/ide/ide-proc.c~ide-use-printk_once drivers/ide/ide-proc.c
--- a/drivers/ide/ide-proc.c~ide-use-printk_once
+++ a/drivers/ide/ide-proc.c
@@ -273,14 +273,8 @@  static const struct ide_proc_devset ide_
 
 static void proc_ide_settings_warn(void)
 {
-	static int warned;
-
-	if (warned)
-		return;
-
-	printk(KERN_WARNING "Warning: /proc/ide/hd?/settings interface is "
+	printk_once(KERN_WARNING "Warning: /proc/ide/hd?/settings interface is "
 			    "obsolete, and will be removed soon!\n");
-	warned = 1;
 }
 
 static int ide_settings_proc_show(struct seq_file *m, void *v)