| Message ID | 20140414062929.GJ1817@tucnak.redhat.com |
|---|---|
| State | New |
| Headers | show |
Jakub Jelinek <jakub@redhat.com> writes: >> I just noticed that I see this error, so the problem still >> exists at r209347 (seen for cris-elf). >> >> (The FAILs are old and provided only for context; the ERRORs are >> fatal.) > > Does say following patch make the problem go away? > > --- gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-11 10:33:22.552213377 +0200 > +++ gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-14 08:27:57.311138264 +0200 > @@ -1,7 +1,7 @@ > // PR c++/60731 > // { dg-do run { target { dlopen && disable-for-4.9 } } } > // { dg-add-options dlopen } > -// { dg-build-dso "dlclose1-dso.cc" } > +// ( dg-build-dso "dlclose1-dso.cc" ) It would: I've used this instead: > -// { dg-build-dso "dlclose1-dso.cc" } > +// { dg- build-dso "dlclose1-dso.cc" } dg-build-dso is evaluated even if the test isn't run. And the problem is indeed the missing support for nested dg-test invocations. I should have known since I provided the patch for that 3 years ago ;-) My suggestion is to leave Jason's reversal for the 4.9 branch. For mainline, we should require DejaGnu >= 1.5, but before reverting the reversal, I'll try to come up with a check that avoids skipping large parts of g++.dg with an older version. Rainer
On Mon, 14 Apr 2014, Jakub Jelinek wrote: > On Sun, Apr 13, 2014 at 09:24:28PM -0400, Hans-Peter Nilsson wrote: > > On Fri, 11 Apr 2014, Jakub Jelinek wrote: > > > > > On Thu, Apr 10, 2014 at 02:18:26PM +0100, Ramana Radhakrishnan wrote: > > > > I see failures from last night on aarch64-none-elf and arm-none-eabi > > > > (both bare-metal) configurations even after moving up to dejagnu > > > > 1.5.1. If this can't be fixed easily should we consider reverting this > > > > patch in the interest of getting sane test results on bare-metal > > > > targets before the release ? > > > > > > > > Should we also update the prereqs page to say dejagnu 1.5.1 ? > > > > (http://gcc.gnu.org/install/prerequisites.html) > > > > > > Jason has disabled the problematic test temporarily last night, can you > > > please verify bare-metal cross-testing now works? > > > > I just noticed that I see this error, so the problem still > > exists at r209347 (seen for cris-elf). > > > > (The FAILs are old and provided only for context; the ERRORs are > > fatal.) > > Does say following patch make the problem go away? Yes, it does, thanks. (Tested by patching with the revertion of the revert, then observing with "make check-c++ 'RUNTESTFLAGS=--target_board=cris-sim RUNTESTFLAGS=dg.exp=dlclose1.C'" that I got: === g++ Summary === # of unsupported tests 3 and in g++.log that those tests were indeed the expected ones.) > --- gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-11 10:33:22.552213377 +0200 > +++ gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-14 08:27:57.311138264 +0200 > @@ -1,7 +1,7 @@ > // PR c++/60731 > // { dg-do run { target { dlopen && disable-for-4.9 } } } > // { dg-add-options dlopen } > -// { dg-build-dso "dlclose1-dso.cc" } > +// ( dg-build-dso "dlclose1-dso.cc" ) > > #include <dlfcn.h> > extern "C" void abort(); brgds, H-P
--- gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-11 10:33:22.552213377 +0200 +++ gcc/gcc/testsuite/g++.dg/dso/dlclose1.C 2014-04-14 08:27:57.311138264 +0200 @@ -1,7 +1,7 @@ // PR c++/60731 // { dg-do run { target { dlopen && disable-for-4.9 } } } // { dg-add-options dlopen } -// { dg-build-dso "dlclose1-dso.cc" } +// ( dg-build-dso "dlclose1-dso.cc" ) #include <dlfcn.h> extern "C" void abort();