diff mbox

[5/6] temporary hack to fix linking error

Message ID 1397382423-4939-6-git-send-email-wbx@openadk.org
State Superseded
Headers show

Commit Message

Waldemar Brodkorb April 13, 2014, 9:47 a.m. UTC
See here for more info:
https://sourceware.org/ml/libc-help/2014-04/msg00020.html

Still working on the issue.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/glibc/2.18/microblaze-libgcc_eh.patch |   18 ++++++++++++++++++
 package/glibc/2.19/microblaze-libgcc_eh.patch |   18 ++++++++++++++++++
 2 files changed, 36 insertions(+)
 create mode 100644 package/glibc/2.18/microblaze-libgcc_eh.patch
 create mode 100644 package/glibc/2.19/microblaze-libgcc_eh.patch

Comments

Gustavo Zacarias April 21, 2014, 3:04 p.m. UTC | #1
On 04/13/2014 06:47 AM, Waldemar Brodkorb wrote:

> See here for more info:
> https://sourceware.org/ml/libc-help/2014-04/msg00020.html
> 
> Still working on the issue.

This patch works, but by it being temporary/hacky it should be
conditionally applied just for microblaze since you probably have no
idea how it can affect other architectures.

By the way, how is it that we're not interested in fixing things or
something like that?
(https://sourceware.org/ml/libc-help/2014-04/msg00027.html)
I'm using my (volunteer/spare) time looking at your patchset and testing
it, so i think that's not a fair assessment, and disabling eglibc
because "no time to test" and saying that at the same time sounds pretty
much like double-standards.
I'm not saying this to get you angry or anything like that, it's just
that you're stating it in a very public mailing list and it seems
utterly unfair to many BR contributors. Many people do what they can
when they can.

Now with that out of the way, care to respin this patch with the
consideration i mentioned above?
Regards.
Waldemar Brodkorb April 22, 2014, 5:49 p.m. UTC | #2
Hi Gustavo,
Gustavo Zacarias wrote,

> On 04/13/2014 06:47 AM, Waldemar Brodkorb wrote:
> 
> > See here for more info:
> > https://sourceware.org/ml/libc-help/2014-04/msg00020.html
> > 
> > Still working on the issue.
> 
> This patch works, but by it being temporary/hacky it should be
> conditionally applied just for microblaze since you probably have no
> idea how it can affect other architectures.
> 
> By the way, how is it that we're not interested in fixing things or
> something like that?
> (https://sourceware.org/ml/libc-help/2014-04/msg00027.html)
> I'm using my (volunteer/spare) time looking at your patchset and testing
> it, so i think that's not a fair assessment, and disabling eglibc
> because "no time to test" and saying that at the same time sounds pretty
> much like double-standards.
> I'm not saying this to get you angry or anything like that, it's just
> that you're stating it in a very public mailing list and it seems
> utterly unfair to many BR contributors. Many people do what they can
> when they can.

Okay, sorry. I thought that there is no interest in my patches,
because I got no feedback at all. Looking at the traffic on the
mailinglist nearly every patch set gets some feedback after 2-3
days. My bug report about the microblaze OOM got no feedback, too. 
I stop whining now, and start hacking.
 
> Now with that out of the way, care to respin this patch with the
> consideration i mentioned above?

I will respin the patches after your gcc 4.9 patch set gets
committed. I tested with gcc 4.9 and the workaround for glibc/eglibc
is not required anymore.

best regards
        Waldemar
Gustavo Zacarias April 22, 2014, 6:29 p.m. UTC | #3
On 04/22/2014 02:49 PM, Waldemar Brodkorb wrote:
> Okay, sorry. I thought that there is no interest in my patches,
> because I got no feedback at all. Looking at the traffic on the
> mailinglist nearly every patch set gets some feedback after 2-3
> days. My bug report about the microblaze OOM got no feedback, too. 
> I stop whining now, and start hacking.

Hi.
Ok, cool, now we're talking! :)

> I will respin the patches after your gcc 4.9 patch set gets
> committed. I tested with gcc 4.9 and the workaround for glibc/eglibc
> is not required anymore.

Great.
Only the gcc patch would need a respin i think, the rest can be
committed as they are.
Thanks.
Regards.
diff mbox

Patch

diff --git a/package/glibc/2.18/microblaze-libgcc_eh.patch b/package/glibc/2.18/microblaze-libgcc_eh.patch
new file mode 100644
index 0000000..a8650df
--- /dev/null
+++ b/package/glibc/2.18/microblaze-libgcc_eh.patch
@@ -0,0 +1,18 @@ 
+diff -Nur glibc-2.19.orig/Makeconfig glibc-2.19/Makeconfig
+--- glibc-2.19.orig/Makeconfig	2014-02-07 10:04:38.000000000 +0100
++++ glibc-2.19/Makeconfig	2014-04-11 08:22:27.000000000 +0200
+@@ -559,12 +559,12 @@
+ # statically link programs.  When --disable-shared is used, we use
+ # -lgcc_eh since elf/static-stubs.o isn't sufficient.
+ ifeq (yes,$(build-shared))
+-static-gnulib = -lgcc $(static-gnulib-arch)
++static-gnulib = -lgcc -lgcc_eh $(static-gnulib-arch)
+ else
+ static-gnulib = -lgcc -lgcc_eh $(static-gnulib-arch)
+ endif
+ static-gnulib-tests := -lgcc -lgcc_eh $(libunwind)
+-libc.so-gnulib := -lgcc
++libc.so-gnulib := -lgcc -lgcc_eh
+ endif
+ +preinit = $(addprefix $(csu-objpfx),crti.o)
+ +postinit = $(addprefix $(csu-objpfx),crtn.o)
diff --git a/package/glibc/2.19/microblaze-libgcc_eh.patch b/package/glibc/2.19/microblaze-libgcc_eh.patch
new file mode 100644
index 0000000..a8650df
--- /dev/null
+++ b/package/glibc/2.19/microblaze-libgcc_eh.patch
@@ -0,0 +1,18 @@ 
+diff -Nur glibc-2.19.orig/Makeconfig glibc-2.19/Makeconfig
+--- glibc-2.19.orig/Makeconfig	2014-02-07 10:04:38.000000000 +0100
++++ glibc-2.19/Makeconfig	2014-04-11 08:22:27.000000000 +0200
+@@ -559,12 +559,12 @@
+ # statically link programs.  When --disable-shared is used, we use
+ # -lgcc_eh since elf/static-stubs.o isn't sufficient.
+ ifeq (yes,$(build-shared))
+-static-gnulib = -lgcc $(static-gnulib-arch)
++static-gnulib = -lgcc -lgcc_eh $(static-gnulib-arch)
+ else
+ static-gnulib = -lgcc -lgcc_eh $(static-gnulib-arch)
+ endif
+ static-gnulib-tests := -lgcc -lgcc_eh $(libunwind)
+-libc.so-gnulib := -lgcc
++libc.so-gnulib := -lgcc -lgcc_eh
+ endif
+ +preinit = $(addprefix $(csu-objpfx),crti.o)
+ +postinit = $(addprefix $(csu-objpfx),crtn.o)