| Message ID | 1397143791-18451-1-git-send-email-tim.gardner@canonical.com |
|---|---|
| State | New |
| Headers | show |
On 04/10/2014 08:29 AM, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/1305480 > > The kerneloops-daemon scans dmesg for common crash signatures, among > which is 'BUG:'. The message emitted by the PCM library is really a > warning, so the most expedient thing to do seems to be to change the > warning string since there is no standard for crash signatures. > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- > sound/core/pcm_lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c > index a210467..2d2e2d6 100644 > --- a/sound/core/pcm_lib.c > +++ b/sound/core/pcm_lib.c > @@ -346,7 +346,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream, > char name[16]; > snd_pcm_debug_name(substream, name, sizeof(name)); > xrun_log_show(substream); > - snd_printd(KERN_ERR "BUG: %s, pos = %ld, " > + snd_printd(KERN_ERR "OVER RUN: %s, pos = %ld, " > "buffer size = %ld, period size = %ld\n", > name, pos, runtime->buffer_size, > runtime->period_size); >
On Thu, Apr 10, 2014 at 09:29:51AM -0600, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/1305480 > > The kerneloops-daemon scans dmesg for common crash signatures, among > which is 'BUG:'. The message emitted by the PCM library is really a > warning, so the most expedient thing to do seems to be to change the > warning string since there is no standard for crash signatures. > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- > sound/core/pcm_lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c > index a210467..2d2e2d6 100644 > --- a/sound/core/pcm_lib.c > +++ b/sound/core/pcm_lib.c > @@ -346,7 +346,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream, > char name[16]; > snd_pcm_debug_name(substream, name, sizeof(name)); > xrun_log_show(substream); > - snd_printd(KERN_ERR "BUG: %s, pos = %ld, " > + snd_printd(KERN_ERR "OVER RUN: %s, pos = %ld, " > "buffer size = %ld, period size = %ld\n", > name, pos, runtime->buffer_size, > runtime->period_size); > -- > 1.7.9.5 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index a210467..2d2e2d6 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -346,7 +346,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream, char name[16]; snd_pcm_debug_name(substream, name, sizeof(name)); xrun_log_show(substream); - snd_printd(KERN_ERR "BUG: %s, pos = %ld, " + snd_printd(KERN_ERR "OVER RUN: %s, pos = %ld, " "buffer size = %ld, period size = %ld\n", name, pos, runtime->buffer_size, runtime->period_size);
BugLink: http://bugs.launchpad.net/bugs/1305480 The kerneloops-daemon scans dmesg for common crash signatures, among which is 'BUG:'. The message emitted by the PCM library is really a warning, so the most expedient thing to do seems to be to change the warning string since there is no standard for crash signatures. Signed-off-by: Tim Gardner <tim.gardner@canonical.com> --- sound/core/pcm_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)