From patchwork Wed Apr 9 17:07:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Cui X-Patchwork-Id: 337885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ve0-f185.google.com (mail-ve0-f185.google.com [209.85.128.185]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8A54E1400DD for ; Thu, 10 Apr 2014 03:10:11 +1000 (EST) Received: by mail-ve0-f185.google.com with SMTP id jw12sf537576veb.22 for ; Wed, 09 Apr 2014 10:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=TmYDkgBeOs86DMMRoRw+IVp3qRS5WlTIuDT5eqYwUt0=; b=cY/cm6EwJjH/MBo3az/gcDnJ0+p2EO9ggulatEUgwji1IVqNAiH7INiJg4Bx5XzWtw 1NqORyyUpdRxENZZ2/AG3ZtAgVv6oC5saa/cqKbi1ievAm3kGqSzoY6hsKkN4T+3XtHx pGuKvV2Rjssd6xvys3bghrtp2bUuUcZQrOPK49kn+QnlfSD0e69KaGV0t/paJ5Uzh9Wb 8DvvNdWQNnjrLmKQwcp0cMwwGe6LV3z6+BFcLfVuQ2lFOZOKWDBOjwoWHk0oYBvKOHCF dnoKNGGcAaEcB1Dnq0zJYZTB7DGL90BTXhF6d16IR3b9hnFkGoqCaK5zA6n1UBKFtaL3 xlPQ== X-Received: by 10.182.51.129 with SMTP id k1mr121191obo.21.1397063408212; Wed, 09 Apr 2014 10:10:08 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.182.186.33 with SMTP id fh1ls417528obc.36.gmail; Wed, 09 Apr 2014 10:10:07 -0700 (PDT) X-Received: by 10.182.153.68 with SMTP id ve4mr5583707obb.39.1397063407695; Wed, 09 Apr 2014 10:10:07 -0700 (PDT) Received: from mail-pb0-x22b.google.com (mail-pb0-x22b.google.com [2607:f8b0:400e:c01::22b]) by gmr-mx.google.com with ESMTPS id vc6si139345pab.2.2014.04.09.10.10.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Apr 2014 10:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of chris.wei.cui@gmail.com designates 2607:f8b0:400e:c01::22b as permitted sender) client-ip=2607:f8b0:400e:c01::22b; Received: by mail-pb0-x22b.google.com with SMTP id um1so2773952pbc.2 for ; Wed, 09 Apr 2014 10:10:07 -0700 (PDT) X-Received: by 10.66.192.162 with SMTP id hh2mr13471117pac.150.1397063407565; Wed, 09 Apr 2014 10:10:07 -0700 (PDT) Received: from localhost.localdomain ([114.224.174.131]) by mx.google.com with ESMTPSA id fg12sm7690738pac.28.2014.04.09.10.10.03 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Apr 2014 10:10:06 -0700 (PDT) From: Chris Cui To: Alessandro Zummo , rtc-linux@googlegroups.com Cc: linux-kernel@vger.kernel.org, Chris Cui Subject: [rtc-linux] [PATCH V2] rtc: fix pcf8523 month definition Date: Thu, 10 Apr 2014 01:07:32 +0800 Message-Id: <1397063252-26065-1-git-send-email-chris.wei.cui@gmail.com> X-Mailer: git-send-email 1.8.3.2 X-Original-Sender: chris.wei.cui@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of chris.wei.cui@gmail.com designates 2607:f8b0:400e:c01::22b as permitted sender) smtp.mail=chris.wei.cui@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , This is the correct patch. PCF8523 uses 1-12 to represent month according to datasheet. link: www.nxp.com/documents/data_sheet/PCF8523.pdf. Signed-off-by: Chris Cui --- drivers/rtc/rtc-pcf8523.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 5c8f822..4cdb64b 100644 --- a/drivers/rtc/rtc-pcf8523.c +++ b/drivers/rtc/rtc-pcf8523.c @@ -206,7 +206,7 @@ static int pcf8523_rtc_read_time(struct device *dev, struct rtc_time *tm) tm->tm_hour = bcd2bin(regs[2] & 0x3f); tm->tm_mday = bcd2bin(regs[3] & 0x3f); tm->tm_wday = regs[4] & 0x7; - tm->tm_mon = bcd2bin(regs[5] & 0x1f); + tm->tm_mon = bcd2bin(regs[5] & 0x1f) - 1; tm->tm_year = bcd2bin(regs[6]) + 100; return rtc_valid_tm(tm); @@ -229,7 +229,7 @@ static int pcf8523_rtc_set_time(struct device *dev, struct rtc_time *tm) regs[3] = bin2bcd(tm->tm_hour); regs[4] = bin2bcd(tm->tm_mday); regs[5] = tm->tm_wday; - regs[6] = bin2bcd(tm->tm_mon); + regs[6] = bin2bcd(tm->tm_mon + 1); regs[7] = bin2bcd(tm->tm_year - 100); msg.addr = client->addr;