| Message ID | 1397048984-22978-1-git-send-email-l.majewski@samsung.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On 09/04/14 22:09, Lukasz Majewski wrote: > During switch to device tree, commit 1ecab0f has removed this code. > > INFORM4 and INFORM5 registers are used by TRATS2 first stage bootloader for > providing recovery. For normal operation, those two must be cleared out. > > This error emerges when one force reset from u-boot's command line for > three times. > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > > --- > Changes for v2: > - Remove redundant cast > --- > board/samsung/trats2/trats2.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/board/samsung/trats2/trats2.c b/board/samsung/trats2/trats2.c > index 2a6c9f9..f558ef9 100644 > --- a/board/samsung/trats2/trats2.c > +++ b/board/samsung/trats2/trats2.c > @@ -150,9 +150,22 @@ static int pmic_init_max77686(void); > > int exynos_init(void) > { > + struct exynos4_power *pwr = > + (struct exynos4_power *)samsung_get_base_power(); > + > check_hw_revision(); > printf("HW Revision:\t0x%04x\n", board_rev); > > + /* > + * First bootloader on the TRATS2 platform uses > + * INFORM4 and INFORM5 registers for recovery > + * > + * To indicate correct boot chain - those two > + * registers must be cleared out > + */ > + writel(0, &pwr->inform4); > + writel(0, &pwr->inform5); > + > return 0; > } > > Acked-by: Minkyu Kang <mk7.kang@samsung.com> Thanks, Minkyu Kang.
On Wed, Apr 09, 2014 at 03:09:44PM +0200, Łukasz Majewski wrote: > During switch to device tree, commit 1ecab0f has removed this code. > > INFORM4 and INFORM5 registers are used by TRATS2 first stage bootloader for > providing recovery. For normal operation, those two must be cleared out. > > This error emerges when one force reset from u-boot's command line for > three times. > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > Acked-by: Minkyu Kang <mk7.kang@samsung.com> Applied to u-boot/master, thanks!
diff --git a/board/samsung/trats2/trats2.c b/board/samsung/trats2/trats2.c index 2a6c9f9..f558ef9 100644 --- a/board/samsung/trats2/trats2.c +++ b/board/samsung/trats2/trats2.c @@ -150,9 +150,22 @@ static int pmic_init_max77686(void); int exynos_init(void) { + struct exynos4_power *pwr = + (struct exynos4_power *)samsung_get_base_power(); + check_hw_revision(); printf("HW Revision:\t0x%04x\n", board_rev); + /* + * First bootloader on the TRATS2 platform uses + * INFORM4 and INFORM5 registers for recovery + * + * To indicate correct boot chain - those two + * registers must be cleared out + */ + writel(0, &pwr->inform4); + writel(0, &pwr->inform5); + return 0; }
During switch to device tree, commit 1ecab0f has removed this code. INFORM4 and INFORM5 registers are used by TRATS2 first stage bootloader for providing recovery. For normal operation, those two must be cleared out. This error emerges when one force reset from u-boot's command line for three times. Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: Minkyu Kang <mk7.kang@samsung.com> --- Changes for v2: - Remove redundant cast --- board/samsung/trats2/trats2.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)