diff mbox

Fixing PR60773

Message ID CAK=A3=372pVhjO2XMPRScgC9=K5Dq1zKettmgvu8sX+sKYjKsA@mail.gmail.com
State New
Headers show

Commit Message

Cong Hou April 9, 2014, 2:40 a.m. UTC 
Thanks for the comments, and the attached file is the updated patch.


thanks,
Cong


On Tue, Apr 8, 2014 at 12:28 AM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> Cong Hou <congh@google.com> writes:
>
>> In the patch of
>> PR60656(http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01668.html), the
>> test case requires GCC to vectorize the widen-mult pattern from si to
>> di types. This may result in test failures on some platforms that
>> don't support this pattern. This patch adds a new target
>> vect_widen_mult_si_to_di_pattern to fix this issue.
>
> Please document the new keyword in gcc/doc/sourcebuild.texi.
>
>> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
>> index 414a745..ea860e7 100644
>> --- a/gcc/testsuite/ChangeLog
>> +++ b/gcc/testsuite/ChangeLog
>> @@ -1,3 +1,11 @@
>> +2014-04-07  Cong Hou  <congh@google.com>
>> +
>> + PR testsuite/60773
>> + * testsuite/lib/target-supports.exp:
>> + Add check_effective_target_vect_widen_mult_si_to_di_pattern.
>> + * gcc.dg/vect/pr60656.c: Update the test by checking if the targets
>> + vect_widen_mult_si_to_di_pattern and vect_long are supported.
>> +
>
> Your mailer is broken: it swallows tabs and breaks long lines.  If you
> can't fix it, please attach patches instead of sending them inline.
>
> Thanks.
>
>         Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
diff mbox

Patch

diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi
index 85ef819..9148608 100644
--- a/gcc/doc/sourcebuild.texi
+++ b/gcc/doc/sourcebuild.texi
@@ -1428,6 +1428,10 @@  Target supports a vector widening multiplication of @code{short} operands
 into @code{int} results, or can promote (unpack) from @code{short} to
 @code{int} and perform non-widening multiplication of @code{int}.
 
+@item vect_widen_mult_si_to_di_pattern
+Target supports a vector widening multiplication of @code{int} operands
+into @code{long} results.
+
 @item vect_sdot_qi
 Target supports a vector dot-product of @code{signed char}.
 
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 414a745..d426e29 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,11 @@ 
+2014-04-07  Cong Hou  <congh@google.com>
+
+	PR testsuite/60773
+	* lib/target-supports.exp:
+	Add check_effective_target_vect_widen_mult_si_to_di_pattern.
+	* gcc.dg/vect/pr60656.c: Update the test by checking if the targets
+	vect_widen_mult_si_to_di_pattern and vect_long are supported.
+
 2014-03-28  Cong Hou  <congh@google.com>
 
 	PR tree-optimization/60656
diff --git a/gcc/testsuite/gcc.dg/vect/pr60656.c b/gcc/testsuite/gcc.dg/vect/pr60656.c
index ebaab62..4950275 100644
--- a/gcc/testsuite/gcc.dg/vect/pr60656.c
+++ b/gcc/testsuite/gcc.dg/vect/pr60656.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target vect_int } */
+/* { dg-require-effective-target vect_long } */
 
 #include "tree-vect.h"
 
@@ -12,7 +13,7 @@  foo ()
   for(i = 0; i < 4; ++i)
     {
       long P = v[i];
-      s += P*P*P;
+      s += P * P * P;
     }
   return s;
 }
@@ -27,7 +28,7 @@  bar ()
   for(i = 0; i < 4; ++i)
     {
       long P = v[i];
-      s += P*P*P;
+      s += P * P * P;
       __asm__ volatile ("");
     }
   return s;
@@ -35,11 +36,12 @@  bar ()
 
 int main()
 {
+  check_vect ();
+
   if (foo () != bar ())
     abort ();
   return 0;
 }
 
-/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */
+/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target vect_widen_mult_si_to_di_pattern } } } */
 /* { dg-final { cleanup-tree-dump "vect" } } */
-
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index bee8471..6d9d689 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -3732,6 +3732,27 @@  proc check_effective_target_vect_widen_mult_hi_to_si_pattern { } {
 }
 
 # Return 1 if the target plus current options supports a vector
+# widening multiplication of *int* args into *long* result, 0 otherwise.
+#
+# This won't change for different subtargets so cache the result.
+
+proc check_effective_target_vect_widen_mult_si_to_di_pattern { } {
+    global et_vect_widen_mult_si_to_di_pattern
+
+    if [info exists et_vect_widen_mult_si_to_di_pattern_saved] {
+        verbose "check_effective_target_vect_widen_mult_si_to_di_pattern: using cached result" 2
+    } else {
+        if {[istarget ia64-*-*]
+              || [istarget i?86-*-*]
+	      || [istarget x86_64-*-*] } {
+            set et_vect_widen_mult_si_to_di_pattern_saved 1
+        }
+    }
+    verbose "check_effective_target_vect_widen_mult_si_to_di_pattern: returning $et_vect_widen_mult_si_to_di_pattern_saved" 2
+    return $et_vect_widen_mult_si_to_di_pattern_saved
+}
+
+# Return 1 if the target plus current options supports a vector
 # widening shift, 0 otherwise.
 #
 # This won't change for different subtargets so cache the result.