| Message ID | 20140408071101.GA14453@gmail.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
2014-04-08 0:11 GMT-07:00 Tobias Waldekranz <tobias@waldekranz.com>: > These functions are exported in include/linux/phy.h but the symbol > exports where missing. Thanks! I had this sitting somewhere and somehow forgot to send it. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/net/phy/phy_device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 0ce6066..7485334 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -695,6 +695,7 @@ int phy_suspend(struct phy_device *phydev) > return phydrv->suspend(phydev); > return 0; > } > +EXPORT_SYMBOL(phy_suspend); > > int phy_resume(struct phy_device *phydev) > { > @@ -704,6 +705,7 @@ int phy_resume(struct phy_device *phydev) > return phydrv->resume(phydev); > return 0; > } > +EXPORT_SYMBOL(phy_resume); > > /* Generic PHY support and helper functions */ > > -- > 1.8.4.357.g8d83871.dirty > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Tobias Waldekranz <tobias@waldekranz.com> Date: Tue, 8 Apr 2014 09:11:01 +0200 > These functions are exported in include/linux/phy.h but the symbol > exports where missing. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> Because they are only used in places where module exports are unnecessary. Presence in foo.h does not automatically mean the symbol should be exported to modules. If you come up with a use case that requires the module export, submit it along with a patch like this. But for now I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Florian Fainelli <f.fainelli@gmail.com> Date: Tue, 8 Apr 2014 08:26:39 -0700 > 2014-04-08 0:11 GMT-07:00 Tobias Waldekranz <tobias@waldekranz.com>: >> These functions are exported in include/linux/phy.h but the symbol >> exports where missing. > > Thanks! I had this sitting somewhere and somehow forgot to send it. > >> >> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> > > Acked-by: Florian Fainelli <f.fainelli@gmail.com> I don't want to see these exported until there is an actual use. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 08, 2014 at 12:29:53PM -0400, David Miller wrote: > From: Tobias Waldekranz <tobias@waldekranz.com> > Date: Tue, 8 Apr 2014 09:11:01 +0200 > > > These functions are exported in include/linux/phy.h but the symbol > > exports where missing. > > > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> > > Because they are only used in places where module exports are unnecessary. > Presence in foo.h does not automatically mean the symbol should be > exported to modules. > > If you come up with a use case that requires the module export, submit > it along with a patch like this. > > But for now I'm not applying this, sorry. Further investigation revealed that I was actually looking for phy_start/stop. Sorry about the noise.
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 0ce6066..7485334 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -695,6 +695,7 @@ int phy_suspend(struct phy_device *phydev) return phydrv->suspend(phydev); return 0; } +EXPORT_SYMBOL(phy_suspend); int phy_resume(struct phy_device *phydev) { @@ -704,6 +705,7 @@ int phy_resume(struct phy_device *phydev) return phydrv->resume(phydev); return 0; } +EXPORT_SYMBOL(phy_resume); /* Generic PHY support and helper functions */
These functions are exported in include/linux/phy.h but the symbol exports where missing. Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> --- drivers/net/phy/phy_device.c | 2 ++ 1 file changed, 2 insertions(+)