| Message ID | 1396900939-21495-3-git-send-email-tlfalcon@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
Am 07.04.2014 22:02, schrieb Thomas Falcon: > This patch allows registers to be properly read from and written to > when using the gdbstub to debug a ppc guest running in little > endian mode. > > Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com> > --- > Differences from v8: > > Separated into multiple patches > ppc_gdb_swap_register(...) is now a static function > Removed "cpu" from the function named > Cleaned up the comments > --- > target-ppc/gdbstub.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/target-ppc/gdbstub.c b/target-ppc/gdbstub.c > index 0740af8..e774db1 100644 > --- a/target-ppc/gdbstub.c > +++ b/target-ppc/gdbstub.c > @@ -59,6 +59,17 @@ static int ppc_gdb_register_len(int n) > } > > > +static void ppc_gdb_swap_register(uint8_t *mem_buf, int n, int len) > +{ > + if (len == 4) { > + bswap32s((uint32_t *)mem_buf); > + } else if (len == 8){ Space missing here, but otherwise Reviewed-by: Andreas Färber <afaerber@suse.de> Regards, Andreas
diff --git a/target-ppc/gdbstub.c b/target-ppc/gdbstub.c index 0740af8..e774db1 100644 --- a/target-ppc/gdbstub.c +++ b/target-ppc/gdbstub.c @@ -59,6 +59,17 @@ static int ppc_gdb_register_len(int n) } +static void ppc_gdb_swap_register(uint8_t *mem_buf, int n, int len) +{ + if (len == 4) { + bswap32s((uint32_t *)mem_buf); + } else if (len == 8){ + bswap64s((uint64_t *)mem_buf); + } else { + g_assert_not_reached(); + } +} + /* Old gdb always expects FP registers. Newer (xml-aware) gdb only * expects whatever the target description contains. Due to a * historical mishap the FP registers appear in between core integer @@ -114,6 +125,10 @@ int ppc_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n) break; } } + if (msr_le) { + /* If cpu is in LE mode, convert memory contents to LE */ + ppc_gdb_swap_register(mem_buf, n, r); + } return r; } @@ -126,6 +141,10 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) if (!r) { return r; } + if (msr_le) { + /* If cpu is in LE mode, convert memory contents to LE. */ + ppc_gdb_swap_register(mem_buf, n, r); + } if (n < 32) { /* gprs */ env->gpr[n] = ldtul_p(mem_buf);
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com> --- Differences from v8: Separated into multiple patches ppc_gdb_swap_register(...) is now a static function Removed "cpu" from the function named Cleaned up the comments --- target-ppc/gdbstub.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)