| Message ID | 1396792574-32169-1-git-send-email-geert@linux-m68k.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Sun, 6 Apr 2014 15:56:14 +0200 > net/tipc/socket.c: In function ‘tipc_release’: > net/tipc/socket.c:352: warning: ‘res’ is used uninitialized in this function > > Introduced by commit 24be34b5a0c9114541891d29dff1152bb1a8df34 ("tipc: > eliminate upcall function pointers between port and socket"), which > removed the sole initializer of "res". > > Just return 0 to fix it. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied, thanks a lot Geert.
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 29b7f26a12cf..adc12e227303 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -301,7 +301,6 @@ static int tipc_release(struct socket *sock) struct tipc_sock *tsk; struct tipc_port *port; struct sk_buff *buf; - int res; /* * Exit if socket isn't fully initialized (occurs when a failed accept() @@ -349,7 +348,7 @@ static int tipc_release(struct socket *sock) sock_put(sk); sock->sk = NULL; - return res; + return 0; } /**
net/tipc/socket.c: In function ‘tipc_release’: net/tipc/socket.c:352: warning: ‘res’ is used uninitialized in this function Introduced by commit 24be34b5a0c9114541891d29dff1152bb1a8df34 ("tipc: eliminate upcall function pointers between port and socket"), which removed the sole initializer of "res". Just return 0 to fix it. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- net/tipc/socket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)