| Message ID | 1396504871-1454-4-git-send-email-tharvey@gateworks.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Tim, On 04/03/2014 09:01 AM, Tim Harvey wrote: > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > --- > arch/arm/cpu/armv7/mx6/u-boot-spl.lds | 52 +++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 arch/arm/cpu/armv7/mx6/u-boot-spl.lds > +1
Hi Tim, On 03/04/2014 08:01, Tim Harvey wrote: > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > --- > arch/arm/cpu/armv7/mx6/u-boot-spl.lds | 52 +++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 arch/arm/cpu/armv7/mx6/u-boot-spl.lds > > diff --git a/arch/arm/cpu/armv7/mx6/u-boot-spl.lds b/arch/arm/cpu/armv7/mx6/u-boot-spl.lds > new file mode 100644 > index 0000000..02aa129 > --- /dev/null > +++ b/arch/arm/cpu/armv7/mx6/u-boot-spl.lds > @@ -0,0 +1,52 @@ > +/* > + * (C) Copyright 2002 > + * Gary Jennejohn, DENX Software Engineering, <garyj@denx.de> > + * > + * (C) Copyright 2010 > + * Texas Instruments, <www.ti.com> > + * Aneesh V <aneesh@ti.com> > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ > + > +MEMORY { .sram : ORIGIN = CONFIG_SPL_TEXT_BASE,\ > + LENGTH = CONFIG_SPL_MAX_SIZE } > +MEMORY { .sdram : ORIGIN = CONFIG_SPL_BSS_START_ADDR, \ > + LENGTH = CONFIG_SPL_BSS_MAX_SIZE } > + > +OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") > +OUTPUT_ARCH(arm) > +ENTRY(_start) > +SECTIONS > +{ > + .text : > + { > + __start = .; > + arch/arm/cpu/armv7/start.o (.text*) > + *(.text*) > + } >.sram > + > + . = ALIGN(4); > + .rodata : { *(SORT_BY_ALIGNMENT(.rodata*)) } >.sram > + > + . = ALIGN(4); > + .data : { *(SORT_BY_ALIGNMENT(.data*)) } >.sram > + > + . = ALIGN(4); > + .u_boot_list : { > + KEEP(*(SORT(.u_boot_list*_i2c_*))); > + } >.sram > + > + . = ALIGN(4); > + __image_copy_end = .; > + _end = .; > + > + .bss : > + { > + . = ALIGN(4); > + __bss_start = .; > + *(.bss*) > + . = ALIGN(4); > + __bss_end = .; > + } >.sdram > +} > This file is pretty identical to ./arch/arm/cpu/armv7/omap-common/u-boot-spl.lds. I understand that each SOC/arch could be a different set up, but I think we should introduce this diversity when it is needed, not as default. Maybe can we avoid to copy the file ? Best regards, Stefano Babic
On Mon, Apr 14, 2014 at 5:02 AM, Stefano Babic <sbabic@denx.de> wrote: > Hi Tim, > <snip> > This file is pretty identical to > ./arch/arm/cpu/armv7/omap-common/u-boot-spl.lds. I understand that each > SOC/arch could be a different set up, but I think we should introduce > this diversity when it is needed, not as default. > > Maybe can we avoid to copy the file ? > Stefano, Yes, I agree - the omap-common file will work for imx6 as well. I will use it and remove this patch. Regards, Tim
On Thu, Apr 17, 2014 at 3:27 AM, Tim Harvey <tharvey@gateworks.com> wrote: > On Mon, Apr 14, 2014 at 5:02 AM, Stefano Babic <sbabic@denx.de> wrote: >> Hi Tim, >> > <snip> >> This file is pretty identical to >> ./arch/arm/cpu/armv7/omap-common/u-boot-spl.lds. I understand that each >> SOC/arch could be a different set up, but I think we should introduce >> this diversity when it is needed, not as default. >> >> Maybe can we avoid to copy the file ? >> > > Stefano, > > Yes, I agree - the omap-common file will work for imx6 as well. I will > use it and remove this patch. So it'd be better to move to spl-common dir?
diff --git a/arch/arm/cpu/armv7/mx6/u-boot-spl.lds b/arch/arm/cpu/armv7/mx6/u-boot-spl.lds new file mode 100644 index 0000000..02aa129 --- /dev/null +++ b/arch/arm/cpu/armv7/mx6/u-boot-spl.lds @@ -0,0 +1,52 @@ +/* + * (C) Copyright 2002 + * Gary Jennejohn, DENX Software Engineering, <garyj@denx.de> + * + * (C) Copyright 2010 + * Texas Instruments, <www.ti.com> + * Aneesh V <aneesh@ti.com> + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +MEMORY { .sram : ORIGIN = CONFIG_SPL_TEXT_BASE,\ + LENGTH = CONFIG_SPL_MAX_SIZE } +MEMORY { .sdram : ORIGIN = CONFIG_SPL_BSS_START_ADDR, \ + LENGTH = CONFIG_SPL_BSS_MAX_SIZE } + +OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") +OUTPUT_ARCH(arm) +ENTRY(_start) +SECTIONS +{ + .text : + { + __start = .; + arch/arm/cpu/armv7/start.o (.text*) + *(.text*) + } >.sram + + . = ALIGN(4); + .rodata : { *(SORT_BY_ALIGNMENT(.rodata*)) } >.sram + + . = ALIGN(4); + .data : { *(SORT_BY_ALIGNMENT(.data*)) } >.sram + + . = ALIGN(4); + .u_boot_list : { + KEEP(*(SORT(.u_boot_list*_i2c_*))); + } >.sram + + . = ALIGN(4); + __image_copy_end = .; + _end = .; + + .bss : + { + . = ALIGN(4); + __bss_start = .; + *(.bss*) + . = ALIGN(4); + __bss_end = .; + } >.sdram +}
Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- arch/arm/cpu/armv7/mx6/u-boot-spl.lds | 52 +++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 arch/arm/cpu/armv7/mx6/u-boot-spl.lds