Patchwork rtc-efi: avoid subtract day twice when computing year days

login
register
mail settings
Submitter Lee, Chun-Yi
Date April 2, 2014, 3:55 a.m.
Message ID <1396410925-5704-1-git-send-email-jlee@suse.com>
Download mbox | patch
Permalink /patch/336229/
State New
Headers show

Comments

Lee, Chun-Yi - April 2, 2014, 3:55 a.m.
Compared source code of rtc-lib.c::rtc_year_days() with
efirtc.c::rtc_year_days(), found the code in rtc-efi decreases value
of day twice when it computing year days. The tc-lib.c::rtc_year_days()
has already decrease day and return the year days from 0 to 365.

Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/rtc/rtc-efi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c
index 797aa02..c4c3843 100644
--- a/drivers/rtc/rtc-efi.c
+++ b/drivers/rtc/rtc-efi.c
@@ -35,7 +35,7 @@  static inline int
 compute_yday(efi_time_t *eft)
 {
 	/* efi_time_t.month is in the [1-12] so, we need -1 */
-	return rtc_year_days(eft->day - 1, eft->month - 1, eft->year);
+	return rtc_year_days(eft->day, eft->month - 1, eft->year);
 }
 /*
  * returns day of the week [0-6] 0=Sunday