diff mbox

[for-2.0,2/2] prep: remove CPU reset entry point hack related to OpenHack'Ware

Message ID 1396387156-5817-3-git-send-email-hpoussin@reactos.org
State New
Headers show

Commit Message

Hervé Poussineau April 1, 2014, 9:19 p.m. UTC 
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

---
 hw/ppc/prep.c |    3 ---
 1 file changed, 3 deletions(-)

Comments

Paolo Bonzini April 2, 2014, 12:48 p.m. UTC | #1 
Il 01/04/2014 23:19, Hervé Poussineau ha scritto:
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>
> ---
>  hw/ppc/prep.c |    3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 035b5b2..dfe4a5c 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -346,9 +346,6 @@ static void ppc_prep_reset(void *opaque)
>      PowerPCCPU *cpu = opaque;
>
>      cpu_reset(CPU(cpu));
> -
> -    /* Reset address */
> -    cpu->env.nip = 0xfffffffc;
>  }
>
>  static const MemoryRegionPortio prep_portio_list[] = {
>

Is ppc_prep_reset needed at all now?

Paolo
Andreas Färber April 2, 2014, 1:47 p.m. UTC | #2 
Am 02.04.2014 14:48, schrieb Paolo Bonzini:
> Il 01/04/2014 23:19, Hervé Poussineau ha scritto:
>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>
>> ---
>>  hw/ppc/prep.c |    3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
>> index 035b5b2..dfe4a5c 100644
>> --- a/hw/ppc/prep.c
>> +++ b/hw/ppc/prep.c
>> @@ -346,9 +346,6 @@ static void ppc_prep_reset(void *opaque)
>>      PowerPCCPU *cpu = opaque;
>>
>>      cpu_reset(CPU(cpu));
>> -
>> -    /* Reset address */
>> -    cpu->env.nip = 0xfffffffc;
>>  }
>>
>>  static const MemoryRegionPortio prep_portio_list[] = {
>>
> 
> Is ppc_prep_reset needed at all now?

I believe so, CPU reset is historically handled by the machines rather
than by CPUs themselves. (also Alpha is an oddball in not handling nor
implementing reset - some WIP on qom-cpu-alpha)

Regards,
Andreas
diff mbox

Patch

diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 035b5b2..dfe4a5c 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -346,9 +346,6 @@  static void ppc_prep_reset(void *opaque)
     PowerPCCPU *cpu = opaque;
 
     cpu_reset(CPU(cpu));
-
-    /* Reset address */
-    cpu->env.nip = 0xfffffffc;
 }
 
 static const MemoryRegionPortio prep_portio_list[] = {