| Message ID | 20140401102903.79BF3FF@mailhost.lps.ens.fr |
|---|---|
| State | New |
| Headers | show |
dominiq@lps.ens.fr (Dominique Dhumieres) writes: > ro@CeBiTec.Uni-Bielefeld.DE (Rainer Orth) wrote: >> Sure, patch preapproved. > > Commited as r208983: > > 2014-04-01 Dominique d'Humieres <dominiq@lps.ens.fr> > Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > PR libgcj/55637 > * testsuite/libjava.lang/sourcelocation.xfail: New file. Btw, the customary format for such a ChangeLog entry is 2014-04-01 Dominique d'Humieres <dominiq@lps.ens.fr> Backport from mainline 2014-02-20 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> PR libgcj/55637 * testsuite/libjava.lang/sourcelocation.xfail: New file. This way, you can easily see when the original went in. Rainer
Thanks for the tip. What should I do now? Should I fix the ChangeLog entry and add a new one or do nothing? Dominique Le 2 avr. 2014 à 12:47, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> a écrit : > dominiq@lps.ens.fr (Dominique Dhumieres) writes: > >> ro@CeBiTec.Uni-Bielefeld.DE (Rainer Orth) wrote: >>> Sure, patch preapproved. >> >> Commited as r208983: >> >> 2014-04-01 Dominique d'Humieres <dominiq@lps.ens.fr> >> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> >> >> PR libgcj/55637 >> * testsuite/libjava.lang/sourcelocation.xfail: New file. > > Btw, the customary format for such a ChangeLog entry is > > 2014-04-01 Dominique d'Humieres <dominiq@lps.ens.fr> > > Backport from mainline > 2014-02-20 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > PR libgcj/55637 > * testsuite/libjava.lang/sourcelocation.xfail: New file. > > This way, you can easily see when the original went in. > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University
Hi Dominique, > Thanks for the tip. What should I do now? Should I fix the ChangeLog entry > and add a new one or do nothing? if you want, you could fix the ChangeLog entry in place, but don't add a new one for that change. Rainer
> if you want, you could fix the ChangeLog entry in place, but don't add a > new one for that change. Done, Dominique
Index: libjava/testsuite/libjava.lang/sourcelocation.xfail =================================================================== --- libjava/testsuite/libjava.lang/sourcelocation.xfail (revision 0) +++ libjava/testsuite/libjava.lang/sourcelocation.xfail (working copy) @@ -0,0 +1 @@ +xfail-output
ro@CeBiTec.Uni-Bielefeld.DE (Rainer Orth) wrote: > Sure, patch preapproved. Commited as r208983: 2014-04-01 Dominique d'Humieres <dominiq@lps.ens.fr> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> PR libgcj/55637 * testsuite/libjava.lang/sourcelocation.xfail: New file. Dominique