From patchwork Mon Sep 14 09:44:20 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 33571 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id E5B3EB7093 for ; Mon, 14 Sep 2009 19:45:24 +1000 (EST) Received: from localhost ([127.0.0.1]:59905 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mn87c-0001nR-UV for incoming@patchwork.ozlabs.org; Mon, 14 Sep 2009 05:45:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mn86q-0001jG-Bi for qemu-devel@nongnu.org; Mon, 14 Sep 2009 05:44:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mn86l-0001Yt-2i for qemu-devel@nongnu.org; Mon, 14 Sep 2009 05:44:31 -0400 Received: from [199.232.76.173] (port=51493 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mn86k-0001YO-Qr for qemu-devel@nongnu.org; Mon, 14 Sep 2009 05:44:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50392) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mn86k-0002tS-8I for qemu-devel@nongnu.org; Mon, 14 Sep 2009 05:44:26 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8E9iNML017360; Mon, 14 Sep 2009 05:44:23 -0400 Received: from zweiblum.home.kraxel.org (vpn1-5-94.ams2.redhat.com [10.36.5.94]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8E9iM1d007739; Mon, 14 Sep 2009 05:44:22 -0400 Message-ID: <4AAE1074.3070203@redhat.com> Date: Mon, 14 Sep 2009 11:44:20 +0200 From: Gerd Hoffmann User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 MIME-Version: 1.0 To: Blue Swirl Subject: Re: [Qemu-devel] Strange qdev related crash (m48t59 ISA qdev conversion) References: In-Reply-To: X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: qemu-devel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hi, > (gdb) p dev->parent_bus > $1 = (BusState *) 0xffffffff00000000 > (gdb) p bus > $2 = (BusState *) 0x26da770 Property definitions are wrong. cheers, Gerd From 87c75662fb5b07c9384662a360a4bc394f9da42d Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Mon, 14 Sep 2009 11:26:40 +0200 Subject: [PATCH] fix --- hw/m48t59.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/m48t59.c b/hw/m48t59.c index a7cfb2f..b9892cc 100644 --- a/hw/m48t59.c +++ b/hw/m48t59.c @@ -719,9 +719,9 @@ static ISADeviceInfo m48t59_isa_info = { .qdev.size = sizeof(M48t59ISAState), .qdev.no_user = 1, .qdev.props = (Property[]) { - DEFINE_PROP_UINT32("size", m48t59_t, size, -1), - DEFINE_PROP_UINT32("type", m48t59_t, type, -1), - DEFINE_PROP_HEX32( "io_base", m48t59_t, io_base, 0), + DEFINE_PROP_UINT32("size", M48t59ISAState, state.size, -1), + DEFINE_PROP_UINT32("type", M48t59ISAState, state.type, -1), + DEFINE_PROP_HEX32( "io_base", M48t59ISAState, state.io_base, 0), DEFINE_PROP_END_OF_LIST(), } }; @@ -731,9 +731,9 @@ static SysBusDeviceInfo m48t59_info = { .qdev.name = "m48t59", .qdev.size = sizeof(M48t59SysBusState), .qdev.props = (Property[]) { - DEFINE_PROP_UINT32("size", m48t59_t, size, -1), - DEFINE_PROP_UINT32("type", m48t59_t, type, -1), - DEFINE_PROP_HEX32( "io_base", m48t59_t, io_base, 0), + DEFINE_PROP_UINT32("size", M48t59SysBusState, state.size, -1), + DEFINE_PROP_UINT32("type", M48t59SysBusState, state.type, -1), + DEFINE_PROP_HEX32( "io_base", M48t59SysBusState, state.io_base, 0), DEFINE_PROP_END_OF_LIST(), } };