From patchwork Sun Sep 13 23:31:11 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: malc X-Patchwork-Id: 33560 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id 3136DB6F2B for ; Mon, 14 Sep 2009 09:32:43 +1000 (EST) Received: from localhost ([127.0.0.1]:50612 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmyYi-0000Pa-5y for incoming@patchwork.ozlabs.org; Sun, 13 Sep 2009 19:32:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmyXP-0008AV-MV for qemu-devel@nongnu.org; Sun, 13 Sep 2009 19:31:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmyXN-000899-Fu for qemu-devel@nongnu.org; Sun, 13 Sep 2009 19:31:19 -0400 Received: from [199.232.76.173] (port=57147 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmyXN-00088z-9b for qemu-devel@nongnu.org; Sun, 13 Sep 2009 19:31:17 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:63601 helo=akado.ru) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MmyXM-0004pM-Sf for qemu-devel@nongnu.org; Sun, 13 Sep 2009 19:31:17 -0400 Received: from [10.0.66.9] ([10.0.66.9] verified) by fe01-cgp.akado.ru (CommuniGate Pro SMTP 5.2.13) with ESMTP id 108535320 for qemu-devel@nongnu.org; Mon, 14 Sep 2009 03:31:10 +0400 Date: Mon, 14 Sep 2009 03:31:11 +0400 (MSD) From: malc X-X-Sender: malc@linmac.oyster.ru To: qemu-devel In-Reply-To: <4AAD4E9B.3010503@web.de> Message-ID: References: <4AACD7DB.2080800@web.de> <4AAD4E9B.3010503@web.de> MIME-Version: 1.0 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: [Qemu-devel] Re: Audio X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Sun, 13 Sep 2009, Jan Kiszka wrote: > malc wrote: > > On Sun, 13 Sep 2009, Jan Kiszka wrote: > > > >> malc wrote: > >>> The code was just commited that enables "polling" audio mode (oss and > >>> alsa), it's also unconditionally enabled now to obtain some testing > >>> coverage, so please give it a whirl, feedback is welcome. > >> CPU load goes to 100% when starting my Musicpal image. Applying the fix > >> below and disabling polling again cures this effect here. > > > > Few things: > > > > Thanks for the patch, but i was at a loss how to properly apply it > > with git and retain all the relevant information (Subject/Authorhsip > > etc), so for the time being it was applied manually. > > Sorry, the patch was so trivial that I became sloppy. > > > > > In the past your mail server was bouncing my replies to threads where > > you paticipated, and since this new CC-ing madness is in place i'm not > > sure whether the list reply was delivered to you either, hence i > > emptied CC header and replying to the list alone. > > Unless the bounce said "mailbox full": Just forward me a recent bounce > message privately (replace web.de with siemens.com). Typically I get > wrong black-listings resolved with web.de within a day or less. No it was something else, i'll forward this message to you to try and get the bounce. > > > > > The Musicpal image i have here is getting stuck somewhere along the > > way to the point of monitor not being responsive, so i can not test > > anything myself. FWIW the command line is this: > > > > [...]/arm-softmmu/qemu-system-arm \ > > -M musicpal \ > > -pflash flash.image \ > > -kernel u-boot.bin \ > > -monitor stdio \ > > -m 128 \ > > -redir tcp:8080::80 -redir tcp:2323::23 > > Hmm, this setup works for me (current master). Maybe you can catch what > strace reports or which backtrace gdb generates. Does disabling polling > or reverting before your changes make it boot again? 930c86820e8e0b6dfcf211bda5e835463d72ff42 is what broke it for me, Following "fixes" it: len = desc.bytes; [..snip..] Now that i have musicpal working, i'll try to investigate things further. diff --git a/hw/musicpal.c b/hw/musicpal.c index 1c4f17c..0fe9fd3 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -238,8 +238,8 @@ static void eth_send(mv88w8618_eth_state *s, int queue_index) uint8_t buf[2048]; int len; - do { + if (!desc_addr) return; eth_tx_desc_get(desc_addr, &desc); if (desc.cmdstat & MP_ETH_TX_OWN) {