Message ID | 20140331164301.GA24150@order.stressinduktion.org |
---|---|
State | RFC, archived |
Delegated to: | David Miller |
Headers | show |
On Mon, Mar 31, 2014 at 1:43 PM, Hannes Frederic Sowa <hannes@stressinduktion.org> wrote: > Would you be able to quickly test this one? > > diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c > index e1e4735..08b367c 100644 > --- a/net/ipv6/mcast.c > +++ b/net/ipv6/mcast.c > @@ -1620,11 +1620,12 @@ static void mld_sendpack(struct sk_buff *skb) > dst_output); > out: > if (!err) { > - ICMP6MSGOUT_INC_STATS_BH(net, idev, ICMPV6_MLD2_REPORT); > - ICMP6_INC_STATS_BH(net, idev, ICMP6_MIB_OUTMSGS); > - IP6_UPD_PO_STATS_BH(net, idev, IPSTATS_MIB_OUTMCAST, payload_len); > - } else > - IP6_INC_STATS_BH(net, idev, IPSTATS_MIB_OUTDISCARDS); > + ICMP6MSGOUT_INC_STATS(net, idev, ICMPV6_MLD2_REPORT); > + ICMP6_INC_STATS(net, idev, ICMP6_MIB_OUTMSGS); > + IP6_UPD_PO_STATS(net, idev, IPSTATS_MIB_OUTMCAST, payload_len); > + } else { > + IP6_INC_STATS(net, idev, IPSTATS_MIB_OUTDISCARDS); > + } Thanks, Hannes. This makes NFS-mount to work fine again: Tested-by: Fabio Estevam <fabio.estevam@freescale.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 31, 2014 at 01:50:58PM -0300, Fabio Estevam wrote: > On Mon, Mar 31, 2014 at 1:43 PM, Hannes Frederic Sowa > <hannes@stressinduktion.org> wrote: > > > Would you be able to quickly test this one? > > > > diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c > > index e1e4735..08b367c 100644 > > --- a/net/ipv6/mcast.c > > +++ b/net/ipv6/mcast.c > > @@ -1620,11 +1620,12 @@ static void mld_sendpack(struct sk_buff *skb) > > dst_output); > > out: > > if (!err) { > > - ICMP6MSGOUT_INC_STATS_BH(net, idev, ICMPV6_MLD2_REPORT); > > - ICMP6_INC_STATS_BH(net, idev, ICMP6_MIB_OUTMSGS); > > - IP6_UPD_PO_STATS_BH(net, idev, IPSTATS_MIB_OUTMCAST, payload_len); > > - } else > > - IP6_INC_STATS_BH(net, idev, IPSTATS_MIB_OUTDISCARDS); > > + ICMP6MSGOUT_INC_STATS(net, idev, ICMPV6_MLD2_REPORT); > > + ICMP6_INC_STATS(net, idev, ICMP6_MIB_OUTMSGS); > > + IP6_UPD_PO_STATS(net, idev, IPSTATS_MIB_OUTMCAST, payload_len); > > + } else { > > + IP6_INC_STATS(net, idev, IPSTATS_MIB_OUTDISCARDS); > > + } > > Thanks, Hannes. This makes NFS-mount to work fine again: > > Tested-by: Fabio Estevam <fabio.estevam@freescale.com> Thanks, Fabio! Eric, do you mind if I take over, I'll audit the rest of the stack regarding this change, too. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2014-03-31 at 18:54 +0200, Hannes Frederic Sowa wrote: > Eric, do you mind if I take over, I'll audit the rest of the stack > regarding this change, too. I do not mind at all ;) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index e1e4735..08b367c 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -1620,11 +1620,12 @@ static void mld_sendpack(struct sk_buff *skb) dst_output); out: if (!err) { - ICMP6MSGOUT_INC_STATS_BH(net, idev, ICMPV6_MLD2_REPORT); - ICMP6_INC_STATS_BH(net, idev, ICMP6_MIB_OUTMSGS); - IP6_UPD_PO_STATS_BH(net, idev, IPSTATS_MIB_OUTMCAST, payload_len); - } else - IP6_INC_STATS_BH(net, idev, IPSTATS_MIB_OUTDISCARDS); + ICMP6MSGOUT_INC_STATS(net, idev, ICMPV6_MLD2_REPORT); + ICMP6_INC_STATS(net, idev, ICMP6_MIB_OUTMSGS); + IP6_UPD_PO_STATS(net, idev, IPSTATS_MIB_OUTMCAST, payload_len); + } else { + IP6_INC_STATS(net, idev, IPSTATS_MIB_OUTDISCARDS); + } rcu_read_unlock(); return;