diff mbox

[U-Boot,v3,13/13] common: fixed linker-list example

Message ID 1396280952-30636-14-git-send-email-m.zalega@samsung.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Mateusz Zalega March 31, 2014, 3:49 p.m. UTC
Change-Id: Id1bab29ec026d83f7e811ba82802aad33f77bea0
Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Tom Rini <trini@ti.com>
---
 include/linker_lists.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut March 31, 2014, 4:12 p.m. UTC | #1
On Monday, March 31, 2014 at 05:49:12 PM, Mateusz Zalega wrote:
> Change-Id: Id1bab29ec026d83f7e811ba82802aad33f77bea0

You samsung guys need to fix your mailers ... and you need to learn to write 
commit messages.

> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@ti.com>

Other than that, please add this for V2:

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  include/linker_lists.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linker_lists.h b/include/linker_lists.h
> index 997d149..557e627 100644
> --- a/include/linker_lists.h
> +++ b/include/linker_lists.h
> @@ -228,7 +228,7 @@
>   * and it's name.
>   *
>   * Example:
> - * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub, cmd.sub) = {
> + * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub) = {
>   *         .x = 3,
>   *         .y = 4,
>   * };

Best regards,
Marek Vasut
Ɓukasz Majewski April 1, 2014, 7:42 a.m. UTC | #2
Hi Marek,

> On Monday, March 31, 2014 at 05:49:12 PM, Mateusz Zalega wrote:
> > Change-Id: Id1bab29ec026d83f7e811ba82802aad33f77bea0

Yes, definitely :-). 
Those Change-Ids are a PITA.

> 
> You samsung guys need to fix your mailers ... and you need to learn
> to write commit messages.
> 
> > Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Tom Rini <trini@ti.com>
> 
> Other than that, please add this for V2:
> 
> Acked-by: Marek Vasut <marex@denx.de>
> 
> > ---
> >  include/linker_lists.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linker_lists.h b/include/linker_lists.h
> > index 997d149..557e627 100644
> > --- a/include/linker_lists.h
> > +++ b/include/linker_lists.h
> > @@ -228,7 +228,7 @@
> >   * and it's name.
> >   *
> >   * Example:
> > - * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub,
> > cmd.sub) = {
> > + * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub) = {
> >   *         .x = 3,
> >   *         .y = 4,
> >   * };
> 
> Best regards,
> Marek Vasut
diff mbox

Patch

diff --git a/include/linker_lists.h b/include/linker_lists.h
index 997d149..557e627 100644
--- a/include/linker_lists.h
+++ b/include/linker_lists.h
@@ -228,7 +228,7 @@ 
  * and it's name.
  *
  * Example:
- * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub, cmd.sub) = {
+ * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub) = {
  *         .x = 3,
  *         .y = 4,
  * };