From patchwork Mon Mar 31 07:03:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "K_s, Vishnu" X-Patchwork-Id: 335213 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id F05AD1400EF for ; Mon, 31 Mar 2014 18:04:19 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=x3EI9Fk4Y2ikc3wQ9mFqFbJQlLZ8nIy+fVGsZTuC/QdqQcuZYQf0O Y8aKdmq0KZHfetrSNU4snSPxjyp3A1oMtC/3AcawY4g1llEQXKqEeCMDm7/2oD0f 77hRdMe0nwRdCifQR4DmwUp+AF6qweLrKBV1TfI4eJVxwcLVm6T9kI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=5lico4tdr/PAvEClDU/yl1EeGcI=; b=stdbYw39Jyaf+jxdKXJNOaY1X5d5 ed40o6UnnDGngJ/qU1XMO5VPDXKJ97vbxJhlcOwyQ7IhcBFknlyxkE48zQxpqM7n J1tlx+lCPj19G94P4f9sQASS1A+8cE43xXUW9BQMfvF3jTv3OYI5WiL9/hNqY7eT oe9/+QOhSkWZy2U= Received: (qmail 31156 invoked by alias); 31 Mar 2014 07:04:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31052 invoked by uid 89); 31 Mar 2014 07:04:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eusmtp01.atmel.com Received: from eusmtp01.atmel.com (HELO eusmtp01.atmel.com) (212.144.249.242) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 31 Mar 2014 07:04:00 +0000 Received: from apsmtp01.atmel.com (10.168.254.30) by eusmtp01.atmel.com (10.161.101.30) with Microsoft SMTP Server id 14.2.347.0; Mon, 31 Mar 2014 09:03:54 +0200 Received: from PENCHT01.corp.atmel.com (10.168.5.161) by apsmtp01.corp.atmel.com (10.168.254.30) with Microsoft SMTP Server (TLS) id 14.2.347.0; Mon, 31 Mar 2014 15:11:46 +0800 Received: from PENMBX01.corp.atmel.com ([10.168.5.210]) by PENCHT01.corp.atmel.com ([fe80::95df:d3d0:4452:28e3%12]) with mapi id 14.02.0342.003; Mon, 31 Mar 2014 15:03:54 +0800 From: "K_s, Vishnu" To: Mike Stump CC: "gcc-patches@gcc.gnu.org" Subject: RE: Changing INT to SI mode Date: Mon, 31 Mar 2014 07:03:53 +0000 Message-ID: <512195FE6C78B243B073F23FF584A73361F93B8C@penmbx01> References: <512195FE6C78B243B073F23FF584A73361F93A85@penmbx01> In-Reply-To: MIME-Version: 1.0 I have found one more test with same issue. 2014-03-31 Vishnu K S * gcc.dg/pr59963-2.c (bazi): Use 32-bit SI mode instead of int. > -----Original Message----- > From: Mike Stump [mailto:mikestump@comcast.net] > Sent: Saturday, March 29, 2014 12:49 AM > To: K_s, Vishnu > Cc: gcc-patches@gcc.gnu.org > Subject: Re: Changing INT to SI mode > > On Mar 28, 2014, at 6:23 AM, K_s, Vishnu wrote: > > Test pr59940.c is failing for AVR target because the test assumes the > size > > of int as 32 bit and test expect to generate warnings for overflow > and > > conversion while assigning 36-bit and 32 bit value respectively to > variable si. > > Following patch define a 32 bit type with SI mode and use it. > > > > 2014-03-28 Vishnu K S > > > > * gcc/testsuite/gcc.dg/pr59940.c: Using 32-bit SI mode instead of > int > > [ see previous note ] > > Ok. > > > I checked this in for you, and formatted the ChangeLog slightly better. > Two spaces after the name, no space before the >, no gcc/testsuite in > the log, end sentence with a period, add name of what was changed (si > in this case). > > +2014-03-28 Vishnu K S > + > + * gcc.dg/pr59940.c (si): Use 32-bit SI mode instead of int. diff --git a/gcc/testsuite/gcc.dg/pr59963-2.c b/gcc/testsuite/gcc.dg/pr59963-2.c index ea05946..263ac37 100644 --- a/gcc/testsuite/gcc.dg/pr59963-2.c +++ b/gcc/testsuite/gcc.dg/pr59963-2.c @@ -2,11 +2,13 @@ /* { dg-do compile } */ /* { dg-options "-Woverflow -Wconversion" } */ +typedef int sitype __attribute__((mode(SI))); + extern void bar (unsigned char); extern void bar8 (unsigned char, unsigned char, unsigned char, unsigned char, unsigned char, unsigned char, unsigned char, unsigned char); extern void bazu (unsigned int, ...); -extern void bazi (char, int); +extern void bazi (char, sitype); extern int f (short a, short b); int