Patchwork Changing INT to SI mode

login
register
mail settings
Submitter K_s, Vishnu
Date March 31, 2014, 7:03 a.m.
Message ID <512195FE6C78B243B073F23FF584A73361F93B8C@penmbx01>
Download mbox | patch
Permalink /patch/335213/
State New
Headers show

Comments

K_s, Vishnu - March 31, 2014, 7:03 a.m.
I have found one more test with same issue.

2014-03-31  Vishnu K S  <Vishnu.k_s@atmel.com>

	* gcc.dg/pr59963-2.c (bazi): Use 32-bit SI mode instead of int.


> -----Original Message-----
> From: Mike Stump [mailto:mikestump@comcast.net]
> Sent: Saturday, March 29, 2014 12:49 AM
> To: K_s, Vishnu
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: Changing INT to SI mode
> 
> On Mar 28, 2014, at 6:23 AM, K_s, Vishnu <Vishnu.K_s@atmel.com> wrote:
> > Test pr59940.c is failing for AVR target because the test assumes the
> size
> > of int as 32 bit and test expect to generate warnings for overflow
> and
> > conversion while assigning 36-bit and 32 bit value respectively to
> variable si.
> > Following patch define a 32 bit type with SI mode and use it.
> >
> > 2014-03-28  Vishnu K S <Vishnu.k_s@atmel.com >
> >
> > 	* gcc/testsuite/gcc.dg/pr59940.c: Using 32-bit SI mode instead of
> int
> 
> [ see previous note ]
> 
> Ok.
> 
> 
> I checked this in for you, and formatted the ChangeLog slightly better.
> Two spaces after the name, no space before the >, no gcc/testsuite in
> the log, end sentence with a period, add name of what was changed (si
> in this case).
> 
> +2014-03-28  Vishnu K S  <Vishnu.k_s@atmel.com>
> +
> +	* gcc.dg/pr59940.c (si): Use 32-bit SI mode instead of int.

Patch

diff --git a/gcc/testsuite/gcc.dg/pr59963-2.c b/gcc/testsuite/gcc.dg/pr59963-2.c
index ea05946..263ac37 100644
--- a/gcc/testsuite/gcc.dg/pr59963-2.c
+++ b/gcc/testsuite/gcc.dg/pr59963-2.c
@@ -2,11 +2,13 @@ 
 /* { dg-do compile } */
 /* { dg-options "-Woverflow -Wconversion" } */

+typedef int sitype __attribute__((mode(SI)));
+
 extern void bar (unsigned char);
 extern void bar8 (unsigned char, unsigned char, unsigned char, unsigned char,
                  unsigned char, unsigned char, unsigned char, unsigned char);
 extern void bazu (unsigned int, ...);
-extern void bazi (char, int);
+extern void bazi (char, sitype);
 extern int f (short a, short b);

 int