| Message ID | 1396023024-2262-28-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Sat, Mar 29, 2014 at 2:10 AM, Peter Maydell <peter.maydell@linaro.org> wrote: > The AArch64 usermode 'any' CPU type was accidentally specified > with the ARM_FEATURE_THUMB2EE bit set. This is incorrect since > ARMv8 removes Thumb2EE completely. Since we never implemented > Thumb2EE anyway having the feature bit set was fairly harmless > for user-mode, but the correct thing is to not set it at all. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > --- > target-arm/cpu64.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c > index 5be7d72..b8b4fa6 100644 > --- a/target-arm/cpu64.c > +++ b/target-arm/cpu64.c > @@ -83,7 +83,6 @@ static void aarch64_any_initfn(Object *obj) > set_feature(&cpu->env, ARM_FEATURE_VFP4); > set_feature(&cpu->env, ARM_FEATURE_VFP_FP16); > set_feature(&cpu->env, ARM_FEATURE_NEON); > - set_feature(&cpu->env, ARM_FEATURE_THUMB2EE); > set_feature(&cpu->env, ARM_FEATURE_ARM_DIV); > set_feature(&cpu->env, ARM_FEATURE_V7MP); > set_feature(&cpu->env, ARM_FEATURE_AARCH64); > -- > 1.9.0 > >
diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 5be7d72..b8b4fa6 100644 --- a/target-arm/cpu64.c +++ b/target-arm/cpu64.c @@ -83,7 +83,6 @@ static void aarch64_any_initfn(Object *obj) set_feature(&cpu->env, ARM_FEATURE_VFP4); set_feature(&cpu->env, ARM_FEATURE_VFP_FP16); set_feature(&cpu->env, ARM_FEATURE_NEON); - set_feature(&cpu->env, ARM_FEATURE_THUMB2EE); set_feature(&cpu->env, ARM_FEATURE_ARM_DIV); set_feature(&cpu->env, ARM_FEATURE_V7MP); set_feature(&cpu->env, ARM_FEATURE_AARCH64);
The AArch64 usermode 'any' CPU type was accidentally specified with the ARM_FEATURE_THUMB2EE bit set. This is incorrect since ARMv8 removes Thumb2EE completely. Since we never implemented Thumb2EE anyway having the feature bit set was fairly harmless for user-mode, but the correct thing is to not set it at all. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target-arm/cpu64.c | 1 - 1 file changed, 1 deletion(-)