From patchwork Fri Mar 28 10:31:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 334647 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6C2EB140082 for ; Fri, 28 Mar 2014 21:31:41 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=My3PhJXdOgy4rCNK0 sQGJ5yUg14/9NFjx/y6mX6x+P2X1p2UBHIG6Q2E40K8MEkgd8FwDtNemB4UbFekF 50/eUhJ/QGcSclqmee+wslp20qBngG9KwXz1NrX1A7dRi7sWZcQntM5no+g1rzWL qE+kFck+ogmA4LYy1jqdVQ0ZZU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; s=default; bh=l6LhFWXBgNn4GfgQdZdlnyi iyAo=; b=V87Mgw6/HfujzPyLMEF//Qub9zpbfgcEXqUbXH3ijkMIYozcePu/ZLu O/aEgXC46lOcdujPwE4ARPorby2oqwThdPfd69kL9QhatF0YTLzqDkQZlJTq7ybH V7kf/rhCGbGuuUG05TZQ8eOX+btiHHQMLtECTv/0SPjQ+1M+w36o= Received: (qmail 5505 invoked by alias); 28 Mar 2014 10:31:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5496 invoked by uid 89); 28 Mar 2014 10:31:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Mar 2014 10:31:33 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2SAVTS4026991 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Mar 2014 06:31:29 -0400 Received: from tucnak.zalov.cz (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2SAVR8M030780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 28 Mar 2014 06:31:28 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.8/8.14.7) with ESMTP id s2SAVPUZ021496; Fri, 28 Mar 2014 11:31:25 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.8/8.14.8/Submit) id s2SAVMxe021495; Fri, 28 Mar 2014 11:31:22 +0100 Date: Fri, 28 Mar 2014 11:31:22 +0100 From: Jakub Jelinek To: Jason Merrill , Rainer Orth Cc: Andreas Schwab , Jason Merrill , gcc-patches List , Jan Hubicka Subject: Re: C++ PATCH for c++/60566 (dtor devirtualization and missing thunks) Message-ID: <20140328103122.GI1817@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <53330512.2090408@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes On Fri, Mar 28, 2014 at 10:06:45AM +0100, Rainer Orth wrote: > > FAIL: g++.dg/abi/thunk6.C -std=c++11 scan-assembler _ZTv0_n32_N1CD1Ev > > > > $ grep _ZTv0_ thunk6.s > > .globl _ZTv0_n16_N1CD1Ev > > .type _ZTv0_n16_N1CD1Ev, @function > > _ZTv0_n16_N1CD1Ev: > > .size _ZTv0_n16_N1CD1Ev, .-_ZTv0_n16_N1CD1Ev > > .globl _ZTv0_n16_N1CD0Ev > > .type _ZTv0_n16_N1CD0Ev, @function > > _ZTv0_n16_N1CD0Ev: > > .size _ZTv0_n16_N1CD0Ev, .-_ZTv0_n16_N1CD0Ev > > It would help to state which target this is... > > Same for the 32-bit multilib on Solaris/SPARC and x86 > (i386-pc-solaris2.11, sparc-sun-solaris2.11). Seems it fails on all ilp32 targets I've tried and succeeds on all lp64 targets (including ia64), so I think we should do following. Ok for trunk? 2014-03-28 Jakub Jelinek PR c++/58678 * g++.dg/abi/thunk6.C: Scan assembler for _ZTv0_n32_N1CD1Ev only for lp64 targets and scan for _ZTv0_n16_N1CD1Ev for ilp32 targets. Jakub --- gcc/testsuite/g++.dg/abi/thunk6.C.jj 2014-03-26 20:31:53.000000000 +0100 +++ gcc/testsuite/g++.dg/abi/thunk6.C 2014-03-28 11:20:45.051852976 +0100 @@ -15,4 +15,5 @@ C::~C() {} int main() {} -// { dg-final { scan-assembler "_ZTv0_n32_N1CD1Ev" } } +// { dg-final { scan-assembler "_ZTv0_n32_N1CD1Ev" { target lp64 } } } +// { dg-final { scan-assembler "_ZTv0_n16_N1CD1Ev" { target ilp32 } } }