From patchwork Fri Sep 11 12:32:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 33459 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id 6ED9AB707B for ; Fri, 11 Sep 2009 23:15:42 +1000 (EST) Received: from localhost ([127.0.0.1]:60214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mm5yU-0001Ce-HU for incoming@patchwork.ozlabs.org; Fri, 11 Sep 2009 09:15:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mm5JH-0004EP-Uo for qemu-devel@nongnu.org; Fri, 11 Sep 2009 08:33:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mm5JC-00047G-HQ for qemu-devel@nongnu.org; Fri, 11 Sep 2009 08:33:02 -0400 Received: from [199.232.76.173] (port=49293 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mm5JC-00046Z-5u for qemu-devel@nongnu.org; Fri, 11 Sep 2009 08:32:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6857) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mm5JB-00046L-Mn for qemu-devel@nongnu.org; Fri, 11 Sep 2009 08:32:58 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8BCWuUO013793 for ; Fri, 11 Sep 2009 08:32:57 -0400 Received: from zweiblum.home.kraxel.org (vpn1-5-42.ams2.redhat.com [10.36.5.42]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id n8BCWlEt024968; Fri, 11 Sep 2009 08:32:50 -0400 Received: by zweiblum.home.kraxel.org (Postfix, from userid 500) id 67EC5700E1; Fri, 11 Sep 2009 14:32:32 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Fri, 11 Sep 2009 14:32:27 +0200 Message-Id: <1252672351-12937-5-git-send-email-kraxel@redhat.com> In-Reply-To: <1252672351-12937-1-git-send-email-kraxel@redhat.com> References: <1252672351-12937-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Gerd Hoffmann Subject: [Qemu-devel] [PATCH 4/8] ide/qdev: add ide bus. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/ide/internal.h | 24 ++++++++++- hw/ide/qdev.c | 123 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 146 insertions(+), 1 deletions(-) create mode 100644 hw/ide/qdev.c diff --git a/hw/ide/internal.h b/hw/ide/internal.h index 62aef1c..9df759d 100644 --- a/hw/ide/internal.h +++ b/hw/ide/internal.h @@ -15,6 +15,8 @@ #define USE_DMA_CDROM typedef struct IDEBus IDEBus; +typedef struct IDEDevice IDEDevice; +typedef struct IDEDeviceInfo IDEDeviceInfo; typedef struct IDEState IDEState; typedef struct BMDMAState BMDMAState; @@ -440,6 +442,8 @@ struct IDEState { struct IDEBus { BusState qbus; + IDEDevice *master; + IDEDevice *slave; BMDMAState *bmdma; IDEState ifs[2]; uint8_t unit; @@ -447,6 +451,20 @@ struct IDEBus { qemu_irq irq; }; +struct IDEDevice { + DeviceState qdev; + uint32_t unit; + DriveInfo *dinfo; +}; + +typedef int (*ide_qdev_initfn)(IDEDevice *dev); +struct IDEDeviceInfo { + DeviceInfo qdev; + ide_qdev_initfn init; + uint32_t unit; + DriveInfo *drive; +}; + #define BM_STATUS_DMAING 0x01 #define BM_STATUS_ERROR 0x02 #define BM_STATUS_INT 0x04 @@ -500,7 +518,7 @@ static inline void ide_set_irq(IDEBus *bus) } } -/* ide.c */ +/* hw/ide/core.c */ void ide_save(QEMUFile* f, IDEState *s); void ide_load(QEMUFile* f, IDEState *s, int version_id); void idebus_save(QEMUFile* f, IDEBus *bus); @@ -532,4 +550,8 @@ void ide_init2(IDEBus *bus, DriveInfo *hd0, DriveInfo *hd1, qemu_irq irq); void ide_init_ioport(IDEBus *bus, int iobase, int iobase2); +/* hw/ide/qdev.c */ +IDEBus *ide_bus_new(DeviceState *dev); +IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive); + #endif /* HW_IDE_INTERNAL_H */ diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c new file mode 100644 index 0000000..6026c28 --- /dev/null +++ b/hw/ide/qdev.c @@ -0,0 +1,123 @@ +/* + * ide bus support for qdev. + * + * Copyright (c) 2009 Gerd Hoffmann + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see . + */ +#include +#include "sysemu.h" +#include "dma.h" + +#include + +/* --------------------------------- */ + +static struct BusInfo ide_bus_info = { + .name = "IDE", + .size = sizeof(IDEBus), +}; + +IDEBus *ide_bus_new(DeviceState *dev) +{ + IDEBus *idebus; + + idebus = FROM_QBUS(IDEBus, qbus_create(&ide_bus_info, dev, NULL)); + return idebus; +} + +static int ide_qdev_init(DeviceState *qdev, DeviceInfo *base) +{ + IDEDevice *dev = DO_UPCAST(IDEDevice, qdev, qdev); + IDEDeviceInfo *info = DO_UPCAST(IDEDeviceInfo, qdev, base); + IDEBus *bus = DO_UPCAST(IDEBus, qbus, qdev->parent_bus); + + if (!dev->dinfo) { + fprintf(stderr, "%s: no drive specified\n", qdev->info->name); + goto err; + } + if (dev->unit == -1) { + dev->unit = bus->master ? 1 : 0; + } + switch (dev->unit) { + case 0: + if (bus->master) { + fprintf(stderr, "ide: tried to assign master twice\n"); + goto err; + } + bus->master = dev; + break; + case 1: + if (bus->slave) { + fprintf(stderr, "ide: tried to assign slave twice\n"); + goto err; + } + bus->slave = dev; + break; + default: + goto err; + } + return info->init(dev); + +err: + return -1; +} + +static void ide_qdev_register(IDEDeviceInfo *info) +{ + info->qdev.init = ide_qdev_init; + info->qdev.bus_info = &ide_bus_info; + qdev_register(&info->qdev); +} + +IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive) +{ + DeviceState *dev; + + dev = qdev_create(&bus->qbus, "ide-drive"); + qdev_prop_set_uint32(dev, "unit", unit); + qdev_prop_set_drive(dev, "drive", drive); + qdev_init(dev); + return DO_UPCAST(IDEDevice, qdev, dev); +} + +/* --------------------------------- */ + +typedef struct IDEDrive { + IDEDevice dev; +} IDEDrive; + +static int ide_drive_initfn(IDEDevice *dev) +{ + IDEBus *bus = DO_UPCAST(IDEBus, qbus, dev->qdev.parent_bus); + ide_init_drive(bus->ifs + dev->unit, dev->dinfo); + return 0; +} + +static IDEDeviceInfo ide_drive_info = { + .qdev.name = "ide-drive", + .qdev.size = sizeof(IDEDrive), + .init = ide_drive_initfn, + .qdev.props = (Property[]) { + DEFINE_PROP_UINT32("unit", IDEDrive, dev.unit, -1), + DEFINE_PROP_DRIVE("drive", IDEDrive, dev.dinfo), + DEFINE_PROP_END_OF_LIST(), + } +}; + +static void ide_drive_register(void) +{ + ide_qdev_register(&ide_drive_info); +} +device_init(ide_drive_register);